Skip to content

add flag sync-remote-cache #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Conversation

gsquared94
Copy link
Contributor

@gsquared94 gsquared94 commented Jul 14, 2021

Fixes: #6145

Description

This PR implements a flag sync-remote-cache which has three values

	// clone missing repositories and sync them on each skaffold run
	always = "always"
	// clone missing repositories but do not sync found repositories
	missing = "missing"
	// do not clone missing repositories, and do not sync found repositories
	never = "never"

This flag allows users to turn off syncing their remote modules on every run of skaffold.
It supersedes the value set in the config.

@gsquared94 gsquared94 requested a review from a team as a code owner July 14, 2021 18:00
@gsquared94 gsquared94 requested a review from MarlonGamez July 14, 2021 18:00
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Jul 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #6210 (c258038) into master (67d8c45) will decrease coverage by 0.28%.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6210      +/-   ##
==========================================
- Coverage   71.16%   70.88%   -0.29%     
==========================================
  Files         481      489       +8     
  Lines       21762    22086     +324     
==========================================
+ Hits        15488    15655     +167     
- Misses       5284     5425     +141     
- Partials      990     1006      +16     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/config/repo_cache.go 59.09% <59.09%> (ø)
pkg/skaffold/git/errors.go 100.00% <100.00%> (ø)
pkg/skaffold/git/gitutil.go 69.23% <100.00%> (+1.41%) ⬆️
pkg/skaffold/log/stream/stream.go 0.00% <0.00%> (-25.00%) ⬇️
pkg/skaffold/kubernetes/logger/log.go 32.53% <0.00%> (-10.84%) ⬇️
pkg/skaffold/docker/image.go 69.93% <0.00%> (-10.16%) ⬇️
pkg/skaffold/build/builder_mux.go 37.70% <0.00%> (-8.30%) ⬇️
pkg/skaffold/sync/sync.go 65.77% <0.00%> (-7.44%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d8c45...c258038. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks

@gsquared94 gsquared94 enabled auto-merge (squash) July 20, 2021 15:48
@gsquared94 gsquared94 merged commit 3cb5c44 into GoogleContainerTools:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide flag to turn off syncing remote modules
3 participants