Skip to content

Set output event context in cache check, tag generation, status check, port forward #6234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarlonGamez
Copy link
Contributor

related: #5368

Description
This PR makes more calls to output.WithEventContext() in order to have SkaffoldLogEvents properly tagged for those parts of execution. This helps IDEs with sorting output.

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 16, 2021 20:43
@MarlonGamez MarlonGamez requested a review from tejal29 July 16, 2021 20:43
@google-cla google-cla bot added the cla: yes label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #6234 (f72cc27) into master (7ea01d1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6234      +/-   ##
==========================================
- Coverage   70.86%   70.83%   -0.04%     
==========================================
  Files         485      487       +2     
  Lines       21951    22053     +102     
==========================================
+ Hits        15556    15621      +65     
- Misses       5397     5425      +28     
- Partials      998     1007       +9     
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 64.40% <100.00%> (+0.30%) ⬆️
...g/skaffold/kubernetes/portforward/entry_manager.go 91.78% <100.00%> (+0.11%) ⬆️
pkg/skaffold/kubernetes/status/status_check.go 52.40% <100.00%> (+0.51%) ⬆️
pkg/skaffold/runner/build.go 74.28% <100.00%> (+0.24%) ⬆️
pkg/skaffold/sync/sync.go 65.77% <0.00%> (-7.44%) ⬇️
pkg/skaffold/hooks/container.go 66.66% <0.00%> (ø)
pkg/skaffold/hooks/sync.go 85.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea01d1...f72cc27. Read the comment docs.

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about adding an integration test for v2 events api for a sample app like microservices.

@tejal29 tejal29 merged commit 23440d4 into GoogleContainerTools:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants