Skip to content

Prefix port forward links with http:// #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

MarlonGamez
Copy link
Contributor

Description
This PR changes the output line that we display when port forwarding by prefixing the links with http://. This was requested by IDE team to make the links clickable. This also seems to make them clickable in terminals as well which is nice.

@MarlonGamez MarlonGamez requested a review from a team as a code owner July 26, 2021 21:56
@MarlonGamez MarlonGamez requested a review from briandealwis July 26, 2021 21:56
@google-cla google-cla bot added the cla: yes label Jul 26, 2021
@MarlonGamez MarlonGamez changed the title pPrefix port forward links with http:// Prefix port forward links with http:// Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #6295 (5c0b214) into main (b50faea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6295   +/-   ##
=======================================
  Coverage   70.79%   70.80%           
=======================================
  Files         494      494           
  Lines       22331    22331           
=======================================
+ Hits        15809    15811    +2     
+ Misses       5502     5501    -1     
+ Partials     1020     1019    -1     
Impacted Files Coverage Δ
...g/skaffold/kubernetes/portforward/entry_manager.go 91.78% <100.00%> (ø)
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50faea...5c0b214. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 4c2c86c into GoogleContainerTools:main Jul 27, 2021
nkubala pushed a commit to nkubala/skaffold that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants