Skip to content

hooks: prepend pod/container name to container hooks log lines #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gsquared94
Copy link
Contributor

Implements #6220 (comment)

Adds pod/container name prefixes to container hooks loglines.
image

@gsquared94 gsquared94 requested a review from nkubala August 2, 2021 10:25
@gsquared94 gsquared94 requested review from yuwenma and a team as code owners August 2, 2021 10:25
@google-cla google-cla bot added the cla: yes label Aug 2, 2021
@gsquared94 gsquared94 changed the title hooks: prepend pod/container name to container hooks hooks: prepend pod/container name to container hooks log lines Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #6337 (b00bf8c) into main (9e8b5de) will increase coverage by 0.02%.
The diff coverage is 79.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6337      +/-   ##
==========================================
+ Coverage   70.59%   70.62%   +0.02%     
==========================================
  Files         496      496              
  Lines       22457    22478      +21     
==========================================
+ Hits        15853    15874      +21     
+ Misses       5583     5578       -5     
- Partials     1021     1026       +5     
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/logger/formatter.go 83.92% <ø> (ø)
pkg/skaffold/sync/sync.go 65.77% <0.00%> (ø)
pkg/skaffold/kubernetes/logger/log.go 34.83% <55.55%> (+2.30%) ⬆️
pkg/skaffold/hooks/container.go 64.44% <63.63%> (-2.23%) ⬇️
.../skaffold/deploy/component/kubernetes/component.go 94.73% <100.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 76.82% <100.00%> (+0.07%) ⬆️
pkg/skaffold/deploy/kpt/kpt.go 79.25% <100.00%> (+0.05%) ⬆️
pkg/skaffold/deploy/kubectl/kubectl.go 68.01% <100.00%> (+0.13%) ⬆️
pkg/skaffold/deploy/kustomize/kustomize.go 72.53% <100.00%> (+0.14%) ⬆️
pkg/skaffold/hooks/host.go 87.50% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8b5de...b00bf8c. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design looks good, I like how you connected the logger's formatter into a disjointed component. see my comment about muting the hook output when logs are muted, otherwise LGTM

@nkubala nkubala merged commit cf4aab8 into GoogleContainerTools:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants