-
Notifications
You must be signed in to change notification settings - Fork 1.7k
hooks: prepend pod/container name to container hooks log lines #6337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: prepend pod/container name to container hooks log lines #6337
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6337 +/- ##
==========================================
+ Coverage 70.59% 70.62% +0.02%
==========================================
Files 496 496
Lines 22457 22478 +21
==========================================
+ Hits 15853 15874 +21
+ Misses 5583 5578 -5
- Partials 1021 1026 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design looks good, I like how you connected the logger's formatter into a disjointed component. see my comment about muting the hook output when logs are muted, otherwise LGTM
Implements #6220 (comment)
Adds pod/container name prefixes to container hooks loglines.
