Skip to content

[docs fixit] update skaffold fix text to have full description of command #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aaron-prindle
Copy link
Contributor

PR updates skaffold fix text on the CLI tab of the skaffold.dev page to be a complete statement about the command with an accurate description

@aaron-prindle aaron-prindle requested a review from a team as a code owner August 30, 2021 04:15
@aaron-prindle aaron-prindle requested a review from tejal29 August 30, 2021 04:15
@google-cla google-cla bot added the cla: yes label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #6536 (208f81e) into main (997edc8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6536      +/-   ##
==========================================
- Coverage   70.43%   70.42%   -0.01%     
==========================================
  Files         515      515              
  Lines       23127    23144      +17     
==========================================
+ Hits        16289    16300      +11     
- Misses       5780     5786       +6     
  Partials     1058     1058              
Impacted Files Coverage Δ
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️
pkg/skaffold/event/v2/event.go 84.58% <0.00%> (-0.06%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/event/v2/build.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/deploy.go 100.00% <0.00%> (ø)
pkg/skaffold/event/v2/logger.go 76.27% <0.00%> (ø)
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (ø)
.../skaffold/kubernetes/status/resource/deployment.go 83.85% <0.00%> (ø)
pkg/skaffold/runner/runcontext/context.go 90.41% <0.00%> (+0.06%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3839f4...208f81e. Read the comment docs.

@aaron-prindle aaron-prindle merged commit 60332e3 into GoogleContainerTools:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants