Skip to content

fix: iterative-status-check only for deployers defining hooks #6574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

gsquared94
Copy link
Contributor

Fixes: #6564

Description

  • Enable iterative status checks for deployers that define at least one deploy hook.
  • The regression is caused by enabling iterative status checks erroneously for all deployers that satisfy the hook runner interface.

@gsquared94 gsquared94 requested a review from a team as a code owner September 8, 2021 10:09
@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #6574 (53602fe) into main (290280e) will decrease coverage by 0.08%.
The diff coverage is 41.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6574      +/-   ##
==========================================
- Coverage   70.48%   70.40%   -0.09%     
==========================================
  Files         515      517       +2     
  Lines       23150    23242      +92     
==========================================
+ Hits        16317    16363      +46     
- Misses       5776     5819      +43     
- Partials     1057     1060       +3     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 70.68% <0.00%> (-0.38%) ⬇️
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/schema/v2beta21/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 85.51% <ø> (ø)
pkg/skaffold/server/server.go 46.87% <0.00%> (-0.75%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af942a...53602fe. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 8, 2021
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 8, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 8, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 8, 2021
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsquared94 gsquared94 merged commit df2066e into GoogleContainerTools:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--iterative-status-check broken in 1.31.0 (modules are always deployed sequentially, and not all at once)
3 participants