Skip to content

refactor: Rename a couple of scripts for consistency #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

refactor: Rename a couple of scripts for consistency #6625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ RUN hack/linter.sh
ERRO Running error: no such linter "gocritic"
```

re-run the `hack/install_golint.sh` script to upgrade `golangci-lint`.
re-run the `hack/install-golint.sh` script to upgrade `golangci-lint`.

### Integration tests

Expand Down
2 changes: 1 addition & 1 deletion hack/boilerplate/boilerplate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@


SKIPPED_DIRS = ["Godeps", "third_party", ".git", "vendor", "examples", "testdata", "node_modules", "codelab"]
SKIPPED_FILES = ["install_golint.sh", "skaffold.pb.go", "skaffold.pb.gw.go", "skaffold_grpc.pb.go", "enums.pb.go", "build.sh", "statik.go", "gitutil.go"]
SKIPPED_FILES = ["install-golint.sh", "skaffold.pb.go", "skaffold.pb.gw.go", "skaffold_grpc.pb.go", "enums.pb.go", "build.sh", "statik.go", "gitutil.go"]

parser = argparse.ArgumentParser()
parser.add_argument("filenames", help="list of files to check, all files if unspecified", nargs='*')
Expand Down
2 changes: 1 addition & 1 deletion hack/golangci-lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ VERSION=1.37.1

function install_linter() {
echo "Installing GolangCI-Lint"
${DIR}/install_golint.sh -b ${BIN} v$VERSION
${DIR}/install-golint.sh -b ${BIN} v$VERSION
}

if ! [ -x "$(command -v ${BIN}/golangci-lint)" ] ; then
Expand Down
0 hack/install_golint.sh → hack/install-golint.sh
View file
Open in desktop
File renamed without changes.
0 hack/new_version.sh → hack/new-version.sh
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion hack/versions/pkg/schema/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func RunSchemaCheckOnChangedFiles() error {
fmt.Printf(" + Check if a new unreleased version has been created:\n")
fmt.Printf(" - Ensure that your branch is up-to-date with the %q branch.\n", baseRef)
fmt.Printf(" - Check for a pending PR to create a new version.\n")
fmt.Printf(" + Create a separate PR with just the result of running the 'hack/new_version.sh' script.\n")
fmt.Printf(" + Create a separate PR with just the result of running the 'hack/new-version.sh' script.\n")

filesInError = append(filesInError, configFile)
}
Expand Down