-
Notifications
You must be signed in to change notification settings - Fork 1.7k
introduce schema v2beta24 #6628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6628 +/- ##
==========================================
- Coverage 70.48% 69.96% -0.52%
==========================================
Files 515 522 +7
Lines 23150 23701 +551
==========================================
+ Hits 16317 16583 +266
- Misses 5776 6035 +259
- Partials 1057 1083 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, have a small nit
Signed-off-by: Ahmet Alp Balkan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✅
I've got Kokoko reproducibly failing on an interactive test ( I don't think I've done anything notable other than clearing the |
@ahmetb I will merge this for now since kokoro is so inconsistent |
Related: #6489