Skip to content

introduce schema v2beta24 #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

introduce schema v2beta24 #6628

merged 1 commit into from
Sep 22, 2021

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Sep 22, 2021

Related: #6489

@ahmetb ahmetb requested a review from a team as a code owner September 22, 2021 16:23
@ahmetb ahmetb requested a review from briandealwis September 22, 2021 16:23
@google-cla google-cla bot added the cla: yes label Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #6628 (29df373) into main (290280e) will decrease coverage by 0.51%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6628      +/-   ##
==========================================
- Coverage   70.48%   69.96%   -0.52%     
==========================================
  Files         515      522       +7     
  Lines       23150    23701     +551     
==========================================
+ Hits        16317    16583     +266     
- Misses       5776     6035     +259     
- Partials     1057     1083      +26     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/diag/recommender/container_errors.go 0.00% <0.00%> (ø)
pkg/diag/validator/pod.go 1.32% <0.00%> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/build/jib/errors.go 48.93% <50.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.32% <66.66%> (-0.73%) ⬇️
pkg/diag/validator/resource.go 47.05% <66.66%> (ø)
pkg/skaffold/build/docker/docker.go 86.44% <66.66%> (-2.85%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e3fa9...29df373. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, have a small nit

@ahmetb ahmetb added the kokoro:force-run forces a kokoro re-run on a PR label Sep 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 22, 2021
Signed-off-by: Ahmet Alp Balkan <[email protected]>
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

@ahmetb
Copy link
Contributor Author

ahmetb commented Sep 22, 2021

I've got Kokoko reproducibly failing on an interactive test (TestDevGracefulCancel/getting-started tracked in #6424).

I don't think I've done anything notable other than clearing the upgrade.go contents, and fixing the upgrade_test.go to have identical expected/want YAMLs. I used the instructions in DEVELOPMENT.md.

https://source.cloud.google.com/results/invocations/0ae17eca-0fda-4f28-8947-d30f12d0efa7/targets/skaffold%2Fpresubmit/log

@MarlonGamez
Copy link
Contributor

@ahmetb I will merge this for now since kokoro is so inconsistent

@MarlonGamez MarlonGamez merged commit cb9037a into GoogleContainerTools:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants