feat:(build/docker): support env as secret source #6632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6632 +/- ##
==========================================
- Coverage 70.48% 70.00% -0.48%
==========================================
Files 515 522 +7
Lines 23150 23705 +555
==========================================
+ Hits 16317 16595 +278
- Misses 5776 6025 +249
- Partials 1057 1085 +28
Continue to review full report at Codecov.
|
ahmetb
changed the title
Used in buildkit mode, allow users to specify secrets provided via env vars to
Skaffold (and hence docker/buildkit) in addition to file sources ("src").
I am setting "src" and "env" as mutually exclusive here in skaffold, however
docker currently does not enforce this (but "env" takes precedence regardless
of the order if both specified).
If we receive issues about this, we can relax
it in a backwards-compatible way.
Signed-off-by: Ahmet Alp Balkan <[email protected]>
tejal29
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6489
Description
Used in buildkit mode, allow users to specify docker secrets provided via env
vars to Skaffold (and hence docker/buildkit) in addition to file sources
("src").
I am setting "src" and "env" as mutually exclusive here in skaffold, however
docker currently does not enforce this (but "env" takes precedence regardless
of the order if both specified).
If we receive issues about this, we can relax
it in a backwards-compatible way.
User facing changes (remove if N/A)
A backwards-compatible new field introduced in the schema (DockerSecret.env)
mutually exclusive with DockerSecret.src.