Add support for skaffold.yml as a default config file fixes #225 #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtseres
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
gtseres
changed the title
r2d4
reviewed
Jun 9, 2018
pkg/skaffold/util/util.go
Outdated
| contents, err := ioutil.ReadFile(filename) | ||
| if err != nil { | ||
| // Try reading the skaffold.yml file instead | ||
| return ioutil.ReadFile(filepath.Join(directory, "skaffold.yml")) |
There was a problem hiding this comment.
Thanks! one nit: can you add a logrus.Infof() here that outputs the error from trying to read the skaffold.yaml and maybe another that says that we're trying to fall back to skaffold.yml? Otherwise the error will just say that it couldn't find "skaffold.yml"
dgageot
reviewed
Jun 10, 2018
pkg/skaffold/util/util_test.go
Outdated
| @@ -108,3 +108,28 @@ func TestExpandPathsGlob(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestDefaultConfigFilenameAlternate(t *testing.T) { | |||
| // Setup a few files in a tempdir. We can't use afero here because it doesn't support symlinks. | |||
There was a problem hiding this comment.
You can remove this comment. We don't use aero anywhere, now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.