Skip to content

chore: make test env check output what was found #6744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2021

Conversation

briandealwis
Copy link
Member

Little change to the testutil's assertCmdEnv function to output the actual environment variable values found. This function is used by RunCmd() and RunCmdOut().

@briandealwis briandealwis requested a review from a team as a code owner October 19, 2021 03:28
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@aaron-prindle
Copy link
Contributor

LGTM. The errors should go away once rebased, were related to an issue fixed by - https://github.com/GoogleContainerTools/skaffold/pull/6752/files

@briandealwis briandealwis enabled auto-merge (squash) October 21, 2021 14:16
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #6744 (9035836) into main (290280e) will decrease coverage by 0.78%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6744      +/-   ##
==========================================
- Coverage   70.48%   69.69%   -0.79%     
==========================================
  Files         515      536      +21     
  Lines       23150    24303    +1153     
==========================================
+ Hits        16317    16938     +621     
- Misses       5776     6249     +473     
- Partials     1057     1116      +59     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/lint.go 52.94% <52.94%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.49% <75.00%> (-0.57%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
cmd/skaffold/app/flags/image.go 76.27% <100.00%> (+3.72%) ⬆️
cmd/skaffold/app/skaffold.go 85.71% <100.00%> (+1.09%) ⬆️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f65f2...9035836. Read the comment docs.

@briandealwis briandealwis merged commit 33dbba4 into GoogleContainerTools:main Oct 30, 2021
@briandealwis briandealwis deleted the test-show-env branch October 30, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants