fix(find-configs): log skaffold.yaml parsing errors at debug #6748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6748 +/- ##
==========================================
- Coverage 70.48% 69.69% -0.79%
==========================================
Files 515 536 +21
Lines 23150 24311 +1161
==========================================
+ Hits 16317 16944 +627
- Misses 5776 6251 +475
- Partials 1057 1116 +59
Continue to review full report at Codecov.
|
tejal29
reviewed
Oct 25, 2021
| @@ -88,7 +89,16 @@ func findConfigs(directory string) (map[string]string, error) { | |||
| } | |||
|
|
|||
| err := walk.From(directory).When(isYaml).Do(func(path string, _ walk.Dirent) error { | |||
| if cfgs, err := schema.ParseConfig(path); err == nil && len(cfgs) > 0 { | |||
| if ctx.Err() != nil { | |||
| return ctx.Err() | |||
There was a problem hiding this comment.
Can we return an actionable error here?
There was a problem hiding this comment.
I only added to fast-exit should the context be cancelled.
briandealwis
force-pushed
the
log-findconfigs-errors
branch
from
05f5788 to
47d7201
Compare
tejal29
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log any errors in
skaffold find-configsat debug level to enable diagnosing why askaffold.yamlis not being recognized.cc: @peterlin741