feat(ko): Add ko builder to local artifact builder #6785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6785 +/- ##
==========================================
- Coverage 70.48% 69.62% -0.86%
==========================================
Files 515 536 +21
Lines 23150 24428 +1278
==========================================
+ Hits 16317 17009 +692
- Misses 5776 6294 +518
- Partials 1057 1125 +68
Continue to review full report at Codecov.
|
halvards
changed the title
briandealwis
approved these changes
Nov 1, 2021
| "github.com/GoogleContainerTools/skaffold/testutil" | ||
| ) | ||
|
|
||
| func Test_newPerArtifactBuilder(t *testing.T) { |
There was a problem hiding this comment.
We've generally been just capitalizing the N as in TestNewPerArtifactBuilder.
| @@ -55,3 +58,41 @@ func TestSourceDependenciesCache(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| func Test_sourceDependenciesForArtifact(t *testing.T) { | |||
There was a problem hiding this comment.
And we'd use TestSourceDependenciesForArtifact
Call the ko builder from the local artifact builder and dependency graph resolver. Tracking: GoogleContainerTools#6041
halvards
force-pushed
the
ko-builder-plumbing
branch
from
9408ee6 to
798793a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call the ko builder from the local artifact builder and dependency graph resolver.
User facing changes
None. Config file unmarshalling still skips ko config.
Tracking: #6041