fix(ko): Fall back to build configs in .ko.yaml
#6821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko build configs are optional, and can either be specified in `skaffold.yaml` or [`.ko.yaml`](https://github.com/google/ko#overriding-go-build-settings). Prior to this change, the Skaffold ko builder would ignore any build configs present in `.ko.yaml`. This happened because we always passed a build config map with one entry, corresponding to the artifact being built. With this change, build configs from `.ko.yaml` will be used as a fallback if the artifact config in `skaffold.yaml` does not specify any of the fields that are part of the build config. This is helpful to existing `ko` users who want to adopt Skaffold. We achieve the fallback behavior by passing an empty build config map, which hits this conditional in `ko`: https://github.com/google/ko/blob/0015a815375d456baed846579ec02cf936b99307/pkg/commands/options/build.go#L120 Tracking: #6041
|
Forgot to update the docs. Converting to draft while I do that. |
Codecov Report
@@ Coverage Diff @@
## main #6821 +/- ##
==========================================
- Coverage 70.48% 69.26% -1.23%
==========================================
Files 515 546 +31
Lines 23150 24986 +1836
==========================================
+ Hits 16317 17306 +989
- Misses 5776 6517 +741
- Partials 1057 1163 +106
Continue to review full report at Codecov.
|
tejal29
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ko build configs are optional, and can either be specified in
skaffold.yamlor.ko.yaml.Prior to this change, the Skaffold ko builder would ignore any build configs present in
.ko.yaml. This happened because we always passed a build config map with one entry, corresponding to the artifact being built.With this change, build configs from
.ko.yamlwill be used as a fallback if the artifact config inskaffold.yamldoes not specify any of the fields that are part of the build config. This is helpful to existingkousers who want to adopt Skaffold.We achieve the fallback behavior by passing an empty build config map, which hits this conditional in
ko: https://github.com/google/ko/blob/0015a815375d456baed846579ec02cf936b99307/pkg/commands/options/build.go#L120Tracking: #6041