Skip to content

fix: fix nil pointer issue for skaff lint when encountering skaffold.yaml with no k8s manifests #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@aaron-prindle aaron-prindle requested a review from a team as a code owner November 11, 2021 00:22
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
@aaron-prindle aaron-prindle force-pushed the fix-skaff-lint-k8smanifests-nil-pointer branch from 96be045 to 1ee1b94 Compare November 11, 2021 00:23
@aaron-prindle aaron-prindle changed the title fix nil pointer issue for skaff lint when encountering skaffold.yaml with no k8s manifests fix: fix nil pointer issue for skaff lint when encountering skaffold.yaml with no k8s manifests Nov 11, 2021
@tejal29
Copy link
Contributor

tejal29 commented Nov 11, 2021

Can you add a unit test for it please.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #6832 (dbc76c5) into main (290280e) will decrease coverage by 1.34%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6832      +/-   ##
==========================================
- Coverage   70.48%   69.13%   -1.35%     
==========================================
  Files         515      547      +32     
  Lines       23150    25034    +1884     
==========================================
+ Hits        16317    17307     +990     
- Misses       5776     6566     +790     
- Partials     1057     1161     +104     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
cmd/skaffold/app/cmd/inspect_build_env.go 65.11% <75.00%> (+6.39%) ⬆️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32a1e8...dbc76c5. Read the comment docs.

@aaron-prindle aaron-prindle force-pushed the fix-skaff-lint-k8smanifests-nil-pointer branch from 1ee1b94 to 72102e2 Compare November 11, 2021 00:52
@aaron-prindle
Copy link
Contributor Author

Can you add a unit test for it please.

done

@aaron-prindle aaron-prindle force-pushed the fix-skaff-lint-k8smanifests-nil-pointer branch from 72102e2 to dbc76c5 Compare November 11, 2021 06:07
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 11, 2021
@tejal29 tejal29 merged commit c70d294 into GoogleContainerTools:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants