Skip to content

fix: fix skaff lint field selector to work more broadly #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@aaron-prindle aaron-prindle requested a review from a team as a code owner November 11, 2021 00:30
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
@aaron-prindle aaron-prindle force-pushed the fix-skaff-lint-field-selector branch from fb8856b to 5971738 Compare November 11, 2021 00:42
@tejal29 tejal29 enabled auto-merge (squash) November 11, 2021 00:43
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #6834 (0df6170) into main (290280e) will decrease coverage by 1.34%.
The diff coverage is 64.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6834      +/-   ##
==========================================
- Coverage   70.48%   69.13%   -1.35%     
==========================================
  Files         515      547      +32     
  Lines       23150    25033    +1883     
==========================================
+ Hits        16317    17307     +990     
- Misses       5776     6564     +788     
- Partials     1057     1162     +105     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
cmd/skaffold/app/cmd/inspect_build_env.go 65.11% <75.00%> (+6.39%) ⬆️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32a1e8...0df6170. Read the comment docs.

@aaron-prindle aaron-prindle force-pushed the fix-skaff-lint-field-selector branch from 5971738 to 0df6170 Compare November 11, 2021 06:07
@tejal29 tejal29 merged commit eb75c85 into GoogleContainerTools:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants