Skip to content

chore(deps): update to kompose 1.26 #6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

briandealwis
Copy link
Member

Update kompose to 1.26.

@briandealwis briandealwis requested a review from a team as a code owner November 16, 2021 16:44
@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@briandealwis briandealwis marked this pull request as draft November 16, 2021 16:44
@briandealwis briandealwis marked this pull request as ready for review November 16, 2021 16:46
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the same change to Dockerfile.deps.lts

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6865 (cfbf681) into main (290280e) will decrease coverage by 1.39%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6865      +/-   ##
==========================================
- Coverage   70.48%   69.08%   -1.40%     
==========================================
  Files         515      547      +32     
  Lines       23150    25078    +1928     
==========================================
+ Hits        16317    17325    +1008     
- Misses       5776     6587     +811     
- Partials     1057     1166     +109     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec848b9...cfbf681. Read the comment docs.

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM there is no compose in LTS image. I confused Kompose with Kustomize.

@tejal29 tejal29 enabled auto-merge (squash) November 16, 2021 18:07
@tejal29 tejal29 disabled auto-merge November 16, 2021 18:07
@tejal29 tejal29 merged commit 70eba2a into GoogleContainerTools:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants