Skip to content

ci: use consistent go build paths caching #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

briandealwis
Copy link
Member

Noticed the Windows tests weren't caching the go build or modules locations. Follow the suggestion here to use go env to retrieve the appropriate paths to cache.

@briandealwis briandealwis requested a review from a team as a code owner January 22, 2022 19:20
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #7044 (d1b641a) into main (290280e) will decrease coverage by 1.68%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7044      +/-   ##
==========================================
- Coverage   70.48%   68.79%   -1.69%     
==========================================
  Files         515      554      +39     
  Lines       23150    25868    +2718     
==========================================
+ Hits        16317    17797    +1480     
- Misses       5776     6866    +1090     
- Partials     1057     1205     +148     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb56aa...d1b641a. Read the comment docs.

@briandealwis briandealwis merged commit 81dd394 into GoogleContainerTools:main Jan 25, 2022
@briandealwis briandealwis deleted the gh-go-cache branch January 25, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants