Skip to content

chore: cleanup default namespace deployment #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Mar 1, 2022

While investigating #7122, I dug into the integration test cluster to find some tests didn't clean up.
This does answer why the integration test cluster had namespaces from past.


NAME                              STATUS        AGE
cnrm-system                       Active        73s
configconnector-operator-system   Active        95s
default                           Active        4y24d
kube-node-lease                   Active        2m17s
kube-public                       Active        4y24d
kube-system                       Active        4y24d
skaffold8cc82                     Terminating   166d
skaffold8nf6w                     Terminating   115s
skaffold8t9hp                     Terminating   204d
skaffold96qvq                     Terminating   152d
skaffold987bj                     Terminating   165d
skaffoldb6tsg                     Terminating   208d
skaffoldbfgtk                     Terminating   165d
skaffoldbnq2w                     Terminating   148d
skaffoldcg68x                     Terminating   204d
skaffoldch92h                     Terminating   145d
skaffoldclw7s                     Terminating   139d
skaffoldcmrz7                     Terminating   6d1h
skaffoldcvt4z                     Terminating   2m6s
skaffolddl88k                     Terminating   166d
skaffolddmclj                     Terminating   174d
skaffoldf52qz                     Terminating   147d
skaffoldf68dv                     Terminating   147d
skaffoldfb8fz                     Terminating   168d
skaffoldfbhdk                     Terminating   151d
skaffoldfc5n7                     Terminating   206d
skaffoldfjbgh                     Terminating   208d
skaffoldfmxrp                     Terminating   169d
skaffoldg4j62                     Terminating   168d
skaffoldg6th9                     Terminating   169d
skaffoldh46mm                     Terminating   151d
skaffoldh6bgt                     Terminating   169d
skaffoldh9tbp                     Terminating   154d
skaffoldhkdqh                     Terminating   117s
skaffoldhkrbl                     Terminating   151d
skaffoldhskts                     Terminating   146d
skaffoldhxq4h                     Terminating   165d
skaffoldhzss7                     Terminating   209d
skaffoldj2g2p                     Terminating   168d
skaffoldjcf9m                     Terminating   167d
skaffoldjjtx5                     Terminating   169d
skaffoldjqjrd                     Terminating   145d
skaffoldjt6k9                     Terminating   12d
skaffoldjtz5b                     Terminating   146d
skaffoldk4rxn                     Terminating   147d
skaffoldkvtz9                     Terminating   207d
skaffoldkwvr9                     Terminating   497d
skaffoldkx9c2                     Terminating   172d
skaffoldkxxnx                     Terminating   17d
skaffoldkz77g                     Terminating   150d
skaffoldlbrh8                     Terminating   187d
skaffoldlccnd                     Terminating   12d
skaffoldlcf8c                     Terminating   172d
skaffoldlfg79                     Terminating   327d
skaffoldlhz7t                     Terminating   368d
skaffoldlj4bw                     Terminating   11d
skaffoldljclm                     Terminating   608d
skaffoldlk7q6                     Terminating   13d
skaffoldllvrn                     Terminating   159d
skaffoldln6np                     Terminating   161d
skaffoldlp67n                     Terminating   2m2s
skaffoldlqjbb                     Terminating   173d
skaffoldls6pw                     Terminating   5d19h
skaffoldltlhb                     Terminating   141d
skaffoldlvcqk                     Terminating   2y4d
skaffoldlvj95                     Terminating   466d
skaffoldm5hbg                     Terminating   194d
skaffoldm74rq                     Terminating   17h
skaffoldm7qtb                     Terminating   193d
skaffoldm86z8                     Terminating   155d
skaffoldmb6ck                     Terminating   375d
skaffoldmbb5c                     Terminating   237d
skaffoldmczqj                     Terminating   43m
skaffoldmd7dp                     Terminating   26d
skaffoldmdzzl                     Terminating   167d
skaffoldmgzpz                     Terminating   349d
skaffoldmnptf                     Terminating   169d
skaffoldmqcww                     Terminating   208d
skaffoldmtcv9                     Terminating   230d
skaffoldn2n7w                     Terminating   149d
skaffoldn2zp4                     Terminating   229d
skaffoldn67x7                     Terminating   146d
skaffoldn6dw5                     Terminating   41d
skaffoldn75bl                     Terminating   406d
skaffoldn75sr                     Terminating   146d
skaffoldn8qh4                     Terminating   20d
skaffoldn8r5l                     Terminating   147d
skaffoldnbjdx                     Terminating   118d
skaffoldndsl2                     Terminating   151d
skaffoldng6gr                     Terminating   174d
skaffoldngf65                     Terminating   160d
skaffoldnhq9s                     Terminating   152d
skaffoldnhs7g                     Terminating   2y4d
skaffoldnk8wv                     Terminating   448d
skaffoldnn5kn                     Terminating   578d
skaffoldnq4lq                     Terminating   169d
skaffoldnqf8w                     Terminating   182d
skaffoldns2kl                     Terminating   6d2h
skaffoldnt2w6                     Terminating   10d
skaffoldnt546                     Terminating   19d
skaffoldnwld8                     Terminating   26m
skaffoldnxg77                     Terminating   252d
skaffoldnxp2s                     Terminating   301d
skaffoldp6bnr                     Terminating   168d
skaffoldp6pp7                     Terminating   146d
skaffoldp98cd                     Terminating   231d
skaffoldp9q6s                     Terminating   532d
skaffoldpdsrq                     Terminating   13d
skaffoldpgjfn                     Terminating   2y4d
skaffoldpgn8g                     Terminating   186d
skaffoldplsjm                     Terminating   153d
skaffoldpnzg8                     Terminating   404d
skaffoldpp975                     Terminating   252d
skaffoldpt5qp                     Terminating   147d
skaffoldpvqqs                     Terminating   145d
skaffoldpzkh8                     Terminating   146d
skaffoldq67ql                     Terminating   151d
skaffoldq9jwh                     Terminating   145d
skaffoldqb5kn                     Terminating   607d
skaffoldqdm65                     Terminating   146d
skaffoldqpcpr                     Terminating   207d
skaffoldqqgrq                     Terminating   181d
skaffoldqqjjg                     Terminating   7d16h
skaffoldqrhd7                     Terminating   531d
skaffoldqshdh                     Terminating   159d
skaffoldqwlg6                     Terminating   151d
skaffoldqwz76                     Terminating   38d
skaffoldr256v                     Terminating   168d
skaffoldr68sv                     Terminating   236d
skaffoldr69kn                     Terminating   169d
skaffoldr7mvq                     Terminating   16h
skaffoldrcsgh                     Terminating   145d
skaffoldrhf88                     Terminating   712d
skaffoldrl8m4                     Terminating   166d
skaffoldrp78f                     Terminating   182d
skaffoldrrb62                     Terminating   151d
skaffoldrv6vw                     Terminating   159d
skaffoldrz6fc                     Terminating   172d
skaffoldrzdsg                     Terminating   165d
skaffolds2v2p                     Terminating   181d
skaffolds68sp                     Terminating   7d20h
skaffolds7v7f                     Terminating   168d
skaffoldsdjt8                     Terminating   272d
skaffoldskgdk                     Terminating   208d
skaffoldsm7dr                     Terminating   161d
skaffoldsn4ns                     Terminating   207d
skaffoldsqf5m                     Terminating   12d
skaffoldsv9cl                     Terminating   91m
skaffoldt24mh                     Terminating   252d
skaffoldt7lsz                     Terminating   148d
skaffoldt7ntm                     Terminating   152d
skaffoldtbpgh                     Terminating   14d
skaffoldtdxr2                     Terminating   157d
skaffoldtkl2j                     Terminating   13d
skaffoldtmwrw                     Terminating   165d
skaffoldtpd2r                     Terminating   10d
skaffoldtt4bq                     Terminating   39h
skaffoldtwdlp                     Terminating   145d
skaffoldtxtx2                     Terminating   249d
skaffoldtzwr6                     Terminating   615d
skaffoldv4qnq                     Terminating   2y4d
skaffoldv7vx9                     Terminating   168d
skaffoldv8fnv                     Terminating   209d
skaffoldvc4kr                     Terminating   165d
skaffoldvgztk                     Terminating   19d
skaffoldvj2nn                     Terminating   208d
skaffoldvpgdc                     Terminating   235d
skaffoldvslw8                     Terminating   158d
skaffoldvw566                     Terminating   187d
skaffoldvxddk                     Terminating   147d
skaffoldvzh26                     Terminating   147d
skaffoldvzhp7                     Terminating   208d
skaffoldw45jh                     Terminating   2m21s
skaffoldw8h45                     Terminating   41d
skaffoldwcc4x                     Terminating   151d
skaffoldwhkk7                     Terminating   145d
skaffoldwm5hf                     Terminating   159d
skaffoldwnmj6                     Terminating   207d
skaffoldwntn8                     Terminating   145d
skaffoldwp4mj                     Terminating   139d
skaffoldwslbw                     Terminating   208d
skaffoldwtfbs                     Terminating   19d
skaffoldwvnt6                     Terminating   140d
skaffoldwxqqn                     Terminating   7d18h
skaffoldx2zx6                     Terminating   167d
skaffoldx8c7j                     Terminating   151d
skaffoldx8mqp                     Terminating   169d
skaffoldx958h                     Terminating   187d
skaffoldxbbl7                     Terminating   41d
skaffoldxgccg                     Terminating   12d
skaffoldxgwph                     Terminating   172d
skaffoldxm5lv                     Terminating   19d
skaffoldxsnlq                     Terminating   85s
skaffoldxvc79                     Terminating   168d
skaffoldxxwbz                     Terminating   11d
skaffoldz5d58                     Terminating   166d
skaffoldz5q77                     Terminating   252d
skaffoldz5s7b                     Terminating   532d
skaffoldz759z                     Terminating   193d
skaffoldz7cnc                     Terminating   12d
skaffoldz7gd7                     Terminating   207d
skaffoldz8qft                     Terminating   20d
skaffoldz92vd                     Terminating   146d
skaffoldzdt7x                     Terminating   159d
skaffoldzf4d8                     Terminating   295d
skaffoldzfp6d                     Terminating   151d
skaffoldzgv7d                     Terminating   187d
skaffoldzh97b                     Terminating   13d
skaffoldzj7pz                     Terminating   154d
skaffoldzkl7t                     Terminating   195d
skaffoldzktrd                     Terminating   244d
skaffoldzllv5                     Terminating   7d19h
skaffoldzlxz9                     Terminating   11d
skaffoldzmtt9                     Terminating   165d
skaffoldzpb9q                     Terminating   166d
skaffoldzq2q8                     Terminating   608d
skaffoldzq48f                     Terminating   160d
skaffoldzqbgr                     Terminating   151d
skaffoldztmq7                     Terminating   217d
skaffoldzxnmm                     Terminating   151d
skaffoldzxw2l                     Terminating   169d


@tejal29 tejal29 requested a review from a team as a code owner March 1, 2022 21:43
@tejal29 tejal29 requested a review from aaron-prindle March 1, 2022 21:43
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #7148 (bb52f2d) into main (290280e) will decrease coverage by 2.16%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7148      +/-   ##
==========================================
- Coverage   70.48%   68.31%   -2.17%     
==========================================
  Files         515      560      +45     
  Lines       23150    26256    +3106     
==========================================
+ Hits        16317    17938    +1621     
- Misses       5776     7073    +1297     
- Partials     1057     1245     +188     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93494e...bb52f2d. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 7881780 into GoogleContainerTools:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants