fix: [V2] TestInspectBuildEnv failing #7170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhodun
changed the title
Codecov Report
@@ Coverage Diff @@
## v2-v1.36.0 #7170 +/- ##
=============================================
Coverage ? 67.62%
=============================================
Files ? 557
Lines ? 26552
Branches ? 0
=============================================
Hits ? 17957
Misses ? 7309
Partials ? 1286 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@dhodun can you amend the commit message to conform with conventional commits? This change looks good ✅ |
dhodun
force-pushed
the
issue_7034_v2_milestone
branch
from
20ec4ac to
bb9c53f
Compare
|
Thanks @dhodun |
tejal29
pushed a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7034
Description:
inputConfigFiles and should be removed afteruseBuildKitbecame nullable field. These were removed on main here: fix: makeuseBuildkitfield nullable across all config versions #6612Follow Up:
I'm a bit perplexed that this change isn't visible in the v2 branch.
git branch --contains=22b0c72c9bd5157ccbd353d7731f2678db20e208indicates that this change is in the various v2 branches. However the history for these files as displayed in the github UI show neither this commit, nor a merge conflict commit undoing the changes: https://github.com/GoogleContainerTools/skaffold/commits/v2-v1.36.0/integration/testdata/inspect/gcb/skaffold.gcb.yaml