-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: remove required tag from cloud run region #7784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7784 +/- ##
==========================================
- Coverage 70.48% 66.65% -3.84%
==========================================
Files 515 590 +75
Lines 23150 28484 +5334
==========================================
+ Hits 16317 18985 +2668
- Misses 5776 8107 +2331
- Partials 1057 1392 +335
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What happens here if |
You're right, we should have validation on this. Is there somewhere in particular the validation should go? If not, I'll add it to cloudrun.NewDeployer. |
validations typically go here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This can now be specified via flag so it's no longer required in the YAML.