Skip to content

fix: remove required tag from cloud run region #7784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

bskaplan
Copy link
Contributor

This can now be specified via flag so it's no longer required in the YAML.

@aaron-prindle aaron-prindle enabled auto-merge (squash) August 17, 2022 20:11
@aaron-prindle aaron-prindle self-requested a review August 17, 2022 20:12
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #7784 (ad4aa17) into main (290280e) will decrease coverage by 3.83%.
The diff coverage is 53.28%.

@@            Coverage Diff             @@
##             main    #7784      +/-   ##
==========================================
- Coverage   70.48%   66.65%   -3.84%     
==========================================
  Files         515      590      +75     
  Lines       23150    28484    +5334     
==========================================
+ Hits        16317    18985    +2668     
- Misses       5776     8107    +2331     
- Partials     1057     1392     +335     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 360 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle disabled auto-merge August 17, 2022 20:47
@aaron-prindle
Copy link
Contributor

aaron-prindle commented Aug 17, 2022

What happens here if region is not specified and the flag is not specified? In this case would it make sense to fail with a message stating region needs to be specified? We might need to add a validation rule and an actionable error here

@bskaplan
Copy link
Contributor Author

You're right, we should have validation on this. Is there somewhere in particular the validation should go? If not, I'll add it to cloudrun.NewDeployer.

@aaron-prindle
Copy link
Contributor

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle enabled auto-merge (squash) August 18, 2022 17:51
@aaron-prindle aaron-prindle merged commit 7c6fd9b into GoogleContainerTools:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants