Skip to content

fix: check platform values for known OS and Arch, and fail fast #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

gsquared94
Copy link
Contributor

Fixes: #7813

Description

Check the values provided to --platform flag and fail fast if unknown.

Testing instruction:

  • In the integration/examples/getting-started project run:
    skaffold build --platform=foo/arm64
    
  • You should get the following error:
    creating runner: getting target platforms: failed to parse platforms: unable to recognise platform "foo/arm64": unknown operating system "foo". Check that the value provided to --platform flag is a valid platform and formatted correctly, like linux/amd64, linux/arm64, linux/arm/v7, etc..
    
  • Again in the integration/examples/getting-started project run:
    skaffold build --platform=linux/foo
    
  • You should get the following error:
    creating runner: getting target platforms: failed to parse platforms: unable to recognise platform "linux/foo": unknown architecture "foo". Check that the value provided to --platform flag is a valid platform and formatted correctly, like linux/amd64, linux/arm64, linux/arm/v7, etc..
    

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #7817 (c2ac3b4) into main (290280e) will decrease coverage by 3.86%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7817      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.87%     
==========================================
  Files         515      593      +78     
  Lines       23150    28668    +5518     
==========================================
+ Hits        16317    19099    +2782     
- Misses       5776     8164    +2388     
- Partials     1057     1405     +348     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 merged commit e744f92 into GoogleContainerTools:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate platforms is not working
2 participants