Skip to content

fix: add remote image support to verify #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

aaron-prindle
Copy link
Contributor

Fixes #7833

Manually verified by deleting all local docker images and attempting to run the following (which pulled the remote images as is desired):

aprindle@aprindle-ssd ~/verify-test $ skaffold verify --build-artifacts artifacts.json
Tags used in verification:
 - integration-test-container -> gcr.io/aprindle-test-cluster/integration-test-container:latest@sha256:4e3ae82a05b09341495807aa60e9e9e54cfdf4cc2113db0330c4a747b9d79d1b
 - metrics-test-container -> gcr.io/aprindle-test-cluster/metrics-test-container:latest@sha256:d1be956070c7ea43ffc1aa84dbfa71ddbe4a9364dbf5e8f8144e212a4623b239
gcr.io/aprindle-test-cluster/integration-test-container@sha256:4e3ae82a05b09341495807aa60e9e9e54cfdf4cc2113db0330c4a747b9d79d1b: Pulling from aprindle-test-cluster/integration-test-container
2408cc74d12b: Pulling fs layer
4b088e8ba4a2: Pulling fs layer
4b088e8ba4a2: Verifying Checksum
4b088e8ba4a2: Download complete
2408cc74d12b: Verifying Checksum
2408cc74d12b: Download complete
2408cc74d12b: Pull complete
4b088e8ba4a2: Pull complete
Digest: sha256:4e3ae82a05b09341495807aa60e9e9e54cfdf4cc2113db0330c4a747b9d79d1b
Status: Downloaded newer image for gcr.io/aprindle-test-cluster/integration-test-container@sha256:4e3ae82a05b09341495807aa60e9e9e54cfdf4cc2113db0330c4a747b9d79d1b
gcr.io/aprindle-test-cluster/metrics-test-container@sha256:d1be956070c7ea43ffc1aa84dbfa71ddbe4a9364dbf5e8f8144e212a4623b239: Pulling from aprindle-test-cluster/metrics-test-container
2408cc74d12b: Already exists
a6a72748a056: Pulling fs layer
a6a72748a056: Verifying Checksum
a6a72748a056: Download complete
a6a72748a056: Pull complete
Digest: sha256:d1be956070c7ea43ffc1aa84dbfa71ddbe4a9364dbf5e8f8144e212a4623b239
Status: Downloaded newer image for gcr.io/aprindle-test-cluster/metrics-test-container@sha256:d1be956070c7ea43ffc1aa84dbfa71ddbe4a9364dbf5e8f8144e212a4623b239
3.15.4: Pulling from aprindle-test-cluster/alpine
df9b9388f04a: Pulling fs layer
df9b9388f04a: Verifying Checksum
df9b9388f04a: Download complete
[integration-test-container] Integration Test 1/4 Running ...
df9b9388f04a: Pull complete
Digest: sha256:a777c9c66ba177ccfea23f2a216ff6721e78a662cd17019488c417135299cd89
Status: Downloaded newer image for gcr.io/aprindle-test-cluster/alpine:3.15.4
[integration-test-container] Integration Test 1/4 Passed!
[metrics-test-container] Metrics test in progress...
[metrics-test-container] Metrics test passed!
[alpine-1] 
[alpine-1] Thu Sep  1 22:47:33 UTC 2022
[alpine-1] Exit Code  is set for this container
[integration-test-container] Integration Test 2/4 Running...!
[integration-test-container] Integration Test 2/4 Passed!
[integration-test-container] Integration Test 3/4 Running...!
[integration-test-container] Integration Test 3/4 Passed!
[integration-test-container] Integration Test 4/4 Running...!
[integration-test-container] Integration Test 4/4 Passed!

@aaron-prindle aaron-prindle added the area/verify Issues related to skaffold verify command label Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #7835 (8410b09) into main (290280e) will decrease coverage by 3.84%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
- Coverage   70.48%   66.63%   -3.85%     
==========================================
  Files         515      593      +78     
  Lines       23150    28711    +5561     
==========================================
+ Hits        16317    19133    +2816     
- Misses       5776     8171    +2395     
- Partials     1057     1407     +350     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle force-pushed the fix-7833 branch 2 times, most recently from c7e72ff to 63853b7 Compare September 2, 2022 00:00
@tejal29 tejal29 merged commit 06dd795 into GoogleContainerTools:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/verify Issues related to skaffold verify command size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify command does not pull images from remote image registries
3 participants