Skip to content

chore: adding status check phase with v2 taskEvent #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericzzzzzzz
Copy link
Contributor

Description

  • This pr adds a v2 status check phase with taskEvent as we have that phase with v1 event.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #7846 (bf7da62) into main (290280e) will decrease coverage by 3.85%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7846      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.86%     
==========================================
  Files         515      593      +78     
  Lines       23150    28714    +5564     
==========================================
+ Hits        16317    19131    +2814     
- Misses       5776     8175    +2399     
- Partials     1057     1408     +351     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericzzzzzzz ericzzzzzzz merged commit 7b98d93 into GoogleContainerTools:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants