-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Add examples to the info sidebar #7906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add examples to the info sidebar #7906
Conversation
@aaron-prindle Could you please review this when you get a chance? Let me know if there are any presubmit steps or conventions I missed. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just ran the updated docs locally and this is working great!
nit: Can you also copy these changes over to |
Codecov Report
@@ Coverage Diff @@
## main #7906 +/- ##
==========================================
- Coverage 70.48% 66.70% -3.78%
==========================================
Files 515 593 +78
Lines 23150 28698 +5548
==========================================
+ Hits 16317 19144 +2827
- Misses 5776 8140 +2364
- Partials 1057 1414 +357
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5439986
to
7445c3f
Compare
My understanding was that docs/layouts/partials/info-panel.html was the partial for v1, and docs-v2/layouts/partials/info-panel.html was the partial for v2. Both are updated; are there updates to any other files required for these changes to take effect in both v1 and v2? |
Sorry, my mistake - I didn't realize both |
Fixes: #6488
Description
Add relevant examples from the examples directory to the sidebar of each page.
User facing changes
Before:
After: