Skip to content

docs: Add banner to v1 and v2 docs indicating that v1 is archived #7920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

maggieneterval
Copy link
Contributor

Fixes: #7910
Related: #7917

Description

User facing changes

V1 screenshot:

mh4NS2E4BkpSKTV

V2 screenshot:

8JZzHFfgRr79bKX

@maggieneterval
Copy link
Contributor Author

@aaron-prindle Wording/placement suggestions welcome! LMK if you would like to provide a release date on the v2 banner.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #7920 (491dfcb) into main (290280e) will decrease coverage by 3.71%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7920      +/-   ##
==========================================
- Coverage   70.48%   66.77%   -3.72%     
==========================================
  Files         515      593      +78     
  Lines       23150    28703    +5553     
==========================================
+ Hits        16317    19165    +2848     
- Misses       5776     8130    +2354     
- Partials     1057     1408     +351     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 366 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tejal29
Copy link
Contributor

tejal29 commented Oct 7, 2022

Look great! Will wait for @aaron-prindle to LGTM before merge.

@tejal29 tejal29 merged commit 56e5b8a into GoogleContainerTools:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants