Skip to content

[Do not merge] chore: bump v1 branch to use go 1.19 for docker image and ci/cd #7942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Oct 13, 2022

Do not Merge!

@aaron-prindle aaron-prindle requested a review from a team as a code owner October 13, 2022 23:01
@aaron-prindle aaron-prindle requested review from cloud-deploy-bot and removed request for a team October 13, 2022 23:01
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v1@894fb67). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             v1    #7942   +/-   ##
=====================================
  Coverage      ?   68.38%           
=====================================
  Files         ?      563           
  Lines         ?    26692           
  Branches      ?        0           
=====================================
  Hits          ?    18253           
  Misses        ?     7174           
  Partials      ?     1265           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 14, 2022
@tejal29 tejal29 changed the title chore: bump v1 branch to use go 1.19 for docker image and ci/cd [Do not merge] chore: bump v1 branch to use go 1.19 for docker image and ci/cd Oct 14, 2022
@tejal29
Copy link
Contributor

tejal29 commented Oct 14, 2022

windows unit tests are failing due to file path issues.

FAIL: TestDockerCLICheckCacheFromArgs (0.04s)
    --- FAIL: TestDockerCLICheckCacheFromArgs/multiple_cache-from_images (0.02s)
        cmd_helper.go:208: 
            wanted: docker build . --file C:\Users\RUNNER~1\AppData\Local\Temp\skaffold2870299162\Dockerfile -t tag --cache-from from/image1 --cache-from from/image2
            
               got: docker build . --file C:\Users\RUNNER~1\AppData\Local\Temp\skaffold2870299[16](https://github.com/GoogleContainerTools/skaffold/actions/runs/3247250545/jobs/5326988867#step:6:17)2\C:\Users\RUNNER~1\AppData\Local\Temp\skaffold2870299162\Dockerfile -t tag --cache-from from/image1 --cache-from from/image2
    --- FAIL: TestDockerCLICheckCacheFromArgs/cache-from_self_uses_tagged_image (0.03s)
        cmd_helper.go:208: 
            wanted: docker build . --file C:\Users\RUNNER~1\AppData\Local\Temp\skaffold3764706[20](https://github.com/GoogleContainerTools/skaffold/actions/runs/3247250545/jobs/5326988867#step:6:21)\Dockerfile -t gcr.io/k8s-skaffold/test:tagged --cache-from gcr.io/k8s-skaffold/test:tagged
            
               got: docker build . --file C:\Users\RUNNER~1\AppData\Local\Temp\skaffold376470620\C:\Users\RUNNER~1\AppData\Local\Temp\skaffold376470620\Dockerfile -t gcr.io/k8s-skaffold/test:tagged --cache-from gcr.io/k8s-skaffold/test:tagged
FAIL

@tejal29
Copy link
Contributor

tejal29 commented Oct 14, 2022

closed in favor of #7943

@tejal29 tejal29 closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants