Skip to content

Avoid nil context error #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Nov 4, 2022

If this code path is followed, we end up with a nil context.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #8038 (0988fa3) into main (290280e) will decrease coverage by 3.93%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #8038      +/-   ##
==========================================
- Coverage   70.48%   66.54%   -3.94%     
==========================================
  Files         515      598      +83     
  Lines       23150    29024    +5874     
==========================================
+ Hits        16317    19314    +2997     
- Misses       5776     8281    +2505     
- Partials     1057     1429     +372     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 392 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

If this code path is followed, we end up with a nil context.
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@aaron-prindle aaron-prindle merged commit dfd6015 into GoogleContainerTools:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants