Skip to content

fix: cleanup not called when using helm deployer alone #8040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Nov 4, 2022

Fixes: #8033
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • deployment can happen without user specifies manifest then deployedManifests will be empty, so in this pr, change dev command to always call cleanup.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #8040 (107061e) into main (290280e) will decrease coverage by 3.92%.
The diff coverage is 53.92%.

@@            Coverage Diff             @@
##             main    #8040      +/-   ##
==========================================
- Coverage   70.48%   66.55%   -3.93%     
==========================================
  Files         515      598      +83     
  Lines       23150    29032    +5882     
==========================================
+ Hits        16317    19323    +3006     
- Misses       5776     8280    +2504     
- Partials     1057     1429     +372     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 393 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/S labels Nov 4, 2022
@tejal29
Copy link
Contributor

tejal29 commented Nov 4, 2022

just a nit. I think can use profiles to override the skaffold.yaml to use helm deployer.

Thanks
Tejal

@ericzzzzzzz ericzzzzzzz merged commit 00ae5e6 into GoogleContainerTools:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup is not working when helm deployer is used with skaffold dev
2 participants