-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: completion for the Fish shell #8097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Codecov Report
@@ Coverage Diff @@
## main #8097 +/- ##
==========================================
- Coverage 70.48% 66.47% -4.02%
==========================================
Files 515 597 +82
Lines 23150 29174 +6024
==========================================
+ Hits 16317 19393 +3076
- Misses 5776 8339 +2563
- Partials 1057 1442 +385
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description
This patch enables Skaffold to generate completion for the Fish shell.
User-facing changes (remove if N/A)
Currently, there's no out-of-the-box completion for the Fish shell, so it needs to be generated manually.
With these changes, the completion looks like the following: