Skip to content

feat: completion for the Fish shell #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022
Merged

feat: completion for the Fish shell #8097

merged 1 commit into from
Nov 15, 2022

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Nov 15, 2022

Description
This patch enables Skaffold to generate completion for the Fish shell.

User-facing changes (remove if N/A)
Currently, there's no out-of-the-box completion for the Fish shell, so it needs to be generated manually.

With these changes, the completion looks like the following:

→ ~ skaffold <TAB>
apply                                                  (Apply hydrated manifests to a cluster)
build                                                                    (Build the artifacts)
completion                   (Output shell completion for the given shell (bash, fish or zsh))
config  (Interact with the global Skaffold config file (defaults to `$HOME/.skaffold/config`))
debug                                                           (Run a pipeline in debug mode)
delete                                             (Delete any resources deployed by Skaffold)
deploy                                                            (Deploy pre-built artifacts)
dev                                                       (Run a pipeline in development mode)
diagnose                                                        (Run a diagnostic on Skaffold)
fix                                       (Update old configuration to a newer schema version)
help                                                                  (Help about any command)
init                                     (Generate configuration for deploying an application)
options
render                                                (Generate rendered Kubernetes manifests)
run                                                                           (Run a pipeline)
schema                        (List JSON schemas used to validate skaffold.yaml configuration)
survey                                   (Opens a web browser to fill out the Skaffold survey)
test                                         (Run tests against your built application images)
verify                                   (Run verification tests against skaffold deployments)
version                                                        (Print the version information)

@morozov morozov changed the title Generate completion for the Fish shell feat: completion for the Fish shell Nov 15, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

morozov added a commit to morozov/dotfiles that referenced this pull request Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #8097 (10cb04f) into main (290280e) will decrease coverage by 4.01%.
The diff coverage is 53.26%.

@@            Coverage Diff             @@
##             main    #8097      +/-   ##
==========================================
- Coverage   70.48%   66.47%   -4.02%     
==========================================
  Files         515      597      +82     
  Lines       23150    29174    +6024     
==========================================
+ Hits        16317    19393    +3076     
- Misses       5776     8339    +2563     
- Partials     1057     1442     +385     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gsquared94 gsquared94 merged commit 4f314d4 into GoogleContainerTools:main Nov 15, 2022
@morozov morozov deleted the fish-completion branch November 15, 2022 05:55
morozov added a commit to morozov/dotfiles that referenced this pull request Mar 10, 2023
morozov added a commit to morozov/dotfiles that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants