Issue #836: Use releaseName to get release info. #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helm release name can be templated so within the `deployRelease` function the `releaseName` variable should be used any time the release name is desired. This commit updates the final call to `getDeployResults` to properly use the `releaseName` variable.
johnmshields
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
|
@johnmshields awesome job. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm release name can be templated so within the
deployReleasefunction the
releaseNamevariable should be used any time the releasename is desired.
This commit updates the final call to
getDeployResultsto properly usethe
releaseNamevariable.#836