Skip to content

Fix plumbing methods broken since ws upgrade to v3 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Sep 23, 2017

In 61fa5ba the ws package got upgraded to v3, which comes with
a breaking change to the connect API. This updates our consumers
to the new API, fixing a crash when initializing the app.

More details on ws v3 breaking changes here

In 61fa5ba the `ws` package got upgraded to v3, which comes with
a breaking change to the `connect` API. This updates our consumers
to the new API, fixing a crash when initializing the app.

More details on `ws` v3 breaking changes [here]
(websockets/ws#1104)
@roperzh roperzh self-assigned this Sep 23, 2017
@matthewtoast
Copy link
Contributor

Thank you for this. I was just about to do this myself. :)

The reason for this upgrade - in case future developers find this - is: Through various work we were doing since our last distro push, our project ended up with multiple versions of 'ws' installed across various sub-projects (both by virtue of 'ws' itself, as well as modules that were once-removed from 'ws', such as a legacy install of 'peerjs'). The 'ws' package, it turns out, depends on several native modules, one of which is called 'bufferutil'. Different versions of 'bufferutil' are extremely picky about what node (platform) versions they can compile on, and that pickiness was preventing our distro pipeline from being able to successfully complete the 'electron-rebuild' step without an exception. For context on that, 'electron-rebuild' is used to compile native modules against a specified electron version, which is required whenever you want to ship an electron app that includes native modules. (Without 'electron-rebuild', we wouldn't be able to use nodegit.) So, I upgraded 'ws' to 3.x, which resolved all the aforementioned issues - but which, of course, also had this breaking change, which I missed!

🌮

@matthewtoast matthewtoast merged commit c40a16c into master Sep 23, 2017
@roperzh roperzh deleted the ws-fixes branch September 25, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants