Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quanshi-meeting.rb #202446

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

quanshi-123
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member

Please do not close and open new PRs as it is difficult to track the reviews.
#202334 (comment)

@quanshi-123
Copy link
Author

How can I solve the problem of pushing the quanshi-meeting.rb file up?

@bevanjkay
Copy link
Member

You can just push to the branch and the PR should automatically update.

@khipp
Copy link
Member

khipp commented Feb 21, 2025

Please remove all documentation comments and run brew style --fix quanshi-meeting.rb to fix any style-related issues.

@quanshi-123
Copy link
Author

% brew style --fix quanshi-meeting.rb
....
1 file inspected, 22 offenses detected, 22 offenses corrected

@khipp
Copy link
Member

khipp commented Feb 21, 2025

Thank you. You still need to commit the changes since the command only modifies your local cask file.

@quanshi-123
Copy link
Author

Thanks, I have already submitted to the GitHub - quanshi-123/homebrew-cask repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants