Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse-t-sshfs 1.0.2 (new cask) #203194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

srozzo
Copy link
Contributor

@srozzo srozzo commented Feb 27, 2025

Added fuse-t-sshfs

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Added fuse-t-sshfs
@srozzo
Copy link
Contributor Author

srozzo commented Feb 27, 2025

Audit output:

▶ brew audit --cask --new fuse-t-sshfs
==> Downloading and extracting artifacts
==> Downloading https://github.com/macos-fuse-t/sshfs/releases/download/1.0.2/sshfs-macos-installer-1.0.2.pkg
Already downloaded: /Users/<redacted>/Library/Caches/Homebrew/downloads/14d161c86a379c0b778cfafafe1721918e16a6a7847b492c6d28b554899613b4--sshfs-macos-installer-1.0.2.pkg
==> Downloading https://github.com/macos-fuse-t/sshfs/releases/download/1.0.2/sshfs-macos-installer-1.0.2.pkg
Already downloaded: /Users/<redacted>/Library/Caches/Homebrew/downloads/14d161c86a379c0b778cfafafe1721918e16a6a7847b492c6d28b554899613b4--sshfs-macos-installer-1.0.2.pkg
audit for fuse-t-sshfs: failed
 - GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
fuse-t-sshfs
  * line 5, col 2: GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 1 problem in 1 cask detected.

Not sure how gating this is.

@khipp khipp changed the title fuse-t-sshfs 1.0.2 fuse-t-sshfs 1.0.2 (new cask) Feb 28, 2025
@bevanjkay
Copy link
Member

Is there a particular reason this cannot be built as a Formula instead?

See https://docs.brew.sh/Acceptable-Casks#rejected-casks

App is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link to the issue from your pull request so we can see the discussion and reasoning for rejection).

@srozzo
Copy link
Contributor Author

srozzo commented Feb 28, 2025

Ok. I will give core a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants