Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-chenyuluoyan: add regular font #203270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

singularitti
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp
Copy link
Member

khipp commented Feb 28, 2025

Could you confirm whether this is the same font? It looks like the upstream repository publishes releases for both a regular and a monospaced variant.

@singularitti
Copy link
Contributor Author

Hi @khipp, no. They are 2 different fonts.

@khipp
Copy link
Member

khipp commented Feb 28, 2025

It would make sense to offer the regular variant under this token. However, I don't think that we should break existing installs by replacing the monospaced variant with the newer font.

@bevanjkay Would it be fine to use version :latest here and install both variants by downloading the latest tarball?

@bevanjkay
Copy link
Member

It looks like the artifact was pushed to the release, but the release itself is much older. We could checkout the repo and install it directly from the git repository - similarly to how the Google Fonts are installed, but we wouldn't be checking out a specific path.

@khipp khipp changed the title font-chenyuluoyan v2.0 font-chenyuluoyan: add regular font Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants