Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thales 2025.02.27 (new formula) #209309

Closed
wants to merge 1 commit into from
Closed

thales 2025.02.27 (new formula) #209309

wants to merge 1 commit into from
+82 −0

Conversation

mikhisaev
Copy link

Created a new Homebrew formula for thales.
This commit includes a new formula file with preliminary tests. Please review and provide feedback.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@mikhisaev
thales 2025.02.27 (new formula)
53def90 
\n\nCreated a new Homebrew formula for thales.
This commit includes a new formula file with preliminary tests.
Please review and provide feedback.
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@botantony
Copy link
Contributor

  1. Homebrew doesn't accept niche packages (less than 75 stars, 30 forks, or 30 watchers)
  2. Binaries in homebrew-core must be build from the source code (for installing pre-build binaries use homebrew-cask repo)
  3. GitHub page of the project without the source code looks very sus

@daeho-ro daeho-ro added the notability Project is not notable enough for inclusion label Mar 1, 2025
@mikhisaev
Copy link
Author

  1. Homebrew doesn't accept niche packages (less than 75 stars, 30 forks, or 30 watchers)

    1. Binaries in homebrew-core must be build from the source code (for installing pre-build binaries use homebrew-cask repo)

    2. GitHub page of the project without the source code looks very sus

That's a fair comment. It doesn't have a lot of stars, but I found it useful that's all.

@SMillerDev
Copy link
Member

Seeing how this PR doesn't really meet the style or content requirements of Homebrew/core I'm going to pass on it. For the future, please see https://docs.brew.sh/Acceptable-Formulae

@SMillerDev SMillerDev closed this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikhisaev @botantony @SMillerDev @daeho-ro