Skip to content

Refactor: Remove nr_samples_per_parameter #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 21, 2021

Conversation

yannikschaelte
Copy link
Member

@yannikschaelte yannikschaelte commented Feb 21, 2021

Solves #54 and #352.

  • Removes the double loop over particles and distances, and the problematic handling of rejected and accepted simulation lists per particle
  • Removes some TODO this only works with nr_samples_per_parameter=1
  • Database left untouched atm

@codecov-io
Copy link

codecov-io commented Feb 21, 2021

Codecov Report

Merging #422 (1630238) into develop (6446a77) will decrease coverage by 40.75%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #422       +/-   ##
============================================
- Coverage    84.08%   43.33%   -40.76%     
============================================
  Files           91       96        +5     
  Lines         5260     5838      +578     
============================================
- Hits          4423     2530     -1893     
- Misses         837     3308     +2471     
Impacted Files Coverage Δ
pyabc/distance/__init__.py 100.00% <ø> (ø)
pyabc/inference/__init__.py 100.00% <ø> (ø)
pyabc/petab/amici.py 0.00% <0.00%> (-85.19%) ⬇️
pyabc/petab/base.py 0.00% <0.00%> (-67.35%) ⬇️
pyabc/populationstrategy.py 52.70% <ø> (-42.17%) ⬇️
pyabc/sampler/redis_eps/server_starter.py 84.61% <ø> (ø)
pyabc/sge/sge.py 0.00% <0.00%> (-45.09%) ⬇️
pyabc/storage/__init__.py 100.00% <ø> (ø)
pyabc/transition/__init__.py 100.00% <ø> (ø)
pyabc/visualization/histogram.py 12.82% <0.00%> (-87.18%) ⬇️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd96cf...1630238. Read the comment docs.

@yannikschaelte yannikschaelte self-assigned this Feb 21, 2021
@yannikschaelte yannikschaelte merged commit 1576aad into develop Feb 21, 2021
@yannikschaelte yannikschaelte deleted the rev_nr_samples_per_particle branch February 21, 2021 22:15
@yannikschaelte yannikschaelte mentioned this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants