-
Notifications
You must be signed in to change notification settings - Fork 44
Minor bug fixes #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes #639
Conversation
* Create ploty versions of selected matplotlib visualizations * update r install instructions * fix pandas float deprecation warnings * fixarray ndim > 0 float extraction deprecationwarning --------- Co-authored-by: Stephan Grein <[email protected]>
#355) * add the functionality to evaluate the model using boundry values of parameter * fix flake8 issues * fix additional flake8 issues * add test case * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * black fixes * Update test_external.py Use correct comparison operator. --------- Co-authored-by: Yannik Schälte <[email protected]> Co-authored-by: Stephan Grein <[email protected]> Co-authored-by: Stephan Grein <[email protected]>
) SimpleModel was removed in 3fc1a52 Co-authored-by: Stephan Grein <[email protected]>
# Conflicts: # setup.cfg
Something with the petab seems to be the problem, working on it |
@arrjon not sure what's the issue, thanks for spending time to debug this. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 84.35% 84.30% -0.06%
==========================================
Files 141 141
Lines 8535 8544 +9
==========================================
+ Hits 7200 7203 +3
- Misses 1335 1341 +6 ☔ View full report in Codecov by Sentry. |
I changed the oldest python version from python 3.9 to 3.10 and updated the GitHub continous integration workflow. This helped with most of the failing tests. |
Adding |
In the migration test, incompatible |
@stephanmg you can review now: only some tests for older python versions are sill in the status "expected" and never leave it (I think because they were part of the old CI workflow, but have been removed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, fixes look good to me. Thanks for the PR.
Some minor bug fixes. These should be corrected in the main version too.