Skip to content

Minor bug fixes #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Oct 29, 2024
Merged

Minor bug fixes #639

merged 36 commits into from
Oct 29, 2024

Conversation

arrjon
Copy link
Collaborator

@arrjon arrjon commented Oct 8, 2024

Some minor bug fixes. These should be corrected in the main version too.

stephanmg and others added 20 commits November 6, 2023 15:07
* Create ploty versions of selected matplotlib visualizations

* update r install instructions

* fix pandas float deprecation warnings

* fixarray ndim > 0 float extraction deprecationwarning

---------

Co-authored-by: Stephan Grein <[email protected]>
#355)

* add the functionality to evaluate the model using boundry values of parameter

* fix flake8 issues

* fix additional flake8 issues

* add test case

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* black fixes

* Update test_external.py

Use correct comparison operator.

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>
# Conflicts:
#	setup.cfg
@arrjon arrjon requested a review from stephanmg October 8, 2024 11:38
@arrjon arrjon self-assigned this Oct 8, 2024
@arrjon arrjon changed the title Develop Minor bug fixes Oct 8, 2024
@arrjon
Copy link
Collaborator Author

arrjon commented Oct 24, 2024

Something with the petab seems to be the problem, working on it

@stephanmg
Copy link
Collaborator

@arrjon not sure what's the issue, thanks for spending time to debug this.

@PaulJonasJost PaulJonasJost reopened this Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (a322de3) to head (b0a1347).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
pyabc/petab/__init__.py 60.00% 2 Missing ⚠️
pyabc/transition/local_transition.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   84.35%   84.30%   -0.06%     
==========================================
  Files         141      141              
  Lines        8535     8544       +9     
==========================================
+ Hits         7200     7203       +3     
- Misses       1335     1341       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arrjon
Copy link
Collaborator Author

arrjon commented Oct 28, 2024

I changed the oldest python version from python 3.9 to 3.10 and updated the GitHub continous integration workflow. This helped with most of the failing tests.

@arrjon
Copy link
Collaborator Author

arrjon commented Oct 28, 2024

Adding | string to env.doc2path() forces Jinja2 to interpret the result as a string, which avoids _StrPath type issues in templates. This should resolve the TypeError by ensuring all path-related operations in nbsphinx_prolog handle paths as strings.

@arrjon
Copy link
Collaborator Author

arrjon commented Oct 28, 2024

In the migration test, incompatible numpy and pandas versions caused an error. This is fixed now.

@arrjon
Copy link
Collaborator Author

arrjon commented Oct 28, 2024

@stephanmg you can review now: only some tests for older python versions are sill in the status "expected" and never leave it (I think because they were part of the old CI workflow, but have been removed).

Copy link
Collaborator

@stephanmg stephanmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, fixes look good to me. Thanks for the PR.

@arrjon arrjon merged commit 57c8d16 into main Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants