Skip to content

feat/ibc_client_module_queries #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

feat/ibc_client_module_queries #321

merged 2 commits into from
Apr 22, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Apr 22, 2024

  • Added support for IBC Core Client module queries
  • Added unit tests
  • Added example scripts

Solves CHAIN-80

Summary by CodeRabbit

  • New Features

    • Added support for all queries in the IBC Channel module and the IBC Client module.
    • Introduced new functionalities for querying IBC client states, consensus states, statuses, and parameters using asynchronous clients.
  • Refactor

    • Enhanced cookies management logic to utilize responses from all gRPC calls.
  • Documentation

    • Updated CHANGELOG.md with details of new query support and refactoring changes.
  • Tests

    • Added test cases for new IBC client and consensus state querying functionalities via gRPC API calls.

@aarmoa aarmoa requested a review from nicolasbaum April 22, 2024 15:18
Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Walkthrough

This update expands support for IBC client queries in the Injective Protocol network, enhancing asynchronous client capabilities. It includes querying client states, consensus states, parameters, and statuses. The cookies management logic has been refined to leverage gRPC responses effectively.

Changes

Files Summary
CHANGELOG.md Added support for all queries in IBC Channel and Client modules; refactored cookies management.
examples/chain_client/ibc/client/query/... Introduces multiple new files for querying various IBC client and consensus states in the Injective Protocol network.
pyinjective/async_client.py, pyinjective/core/ibc/client/ibc_client_grpc_api.py Expanded async_client.py to include IBC client operations; introduced IBCClientGrpcApi for handling IBC client-related gRPC interactions.
pyinjective/core/ibc/channel/grpc/ibc_channel_grpc_api.py Updated import statement for Channel class.
tests/core/ibc/client/grpc/... Added new test files for IBC client and consensus state queries using gRPC API.

🐰✨
A hop, a skip, a code deploy,
New queries galore, oh what a joy!
IBC clients chatter, consensus align,
In the digital warren, all intertwine.
🌟🌿🥕


Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3f777fb and e074077.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (141)
CHANGELOG.md (141)

Near line 7: Possible spelling mistake found.
Context: ...- Support for all queries in the chain "tendermint" module - Support for all queries in th...


Near line 22: Possible spelling mistake found.
Context: ...4.2] - 2024-03-19 ### Changed - Updated aiohttp dependency version to ">=3.9.2" to sol...


Near line 29: Possible typo: you repeated a word
Context: ...ed methods ## [1.4.0] - 2024-03-11 ### Added - Added support for all queries and messages in...


Near line 32: Possible spelling mistake found.
Context: ...in the chain 'exchange' module - Use of python-dotenv in all example scripts to load private ...


Near line 40: Possible spelling mistake found.
Context: ...3.0] - 2024-02-12 ### Changed - Removed asyncio from the dependencies ## [1.2.0] - 20...


Near line 50: Possible spelling mistake found.
Context: ...Changed - Updated the logic to create a MsgLiquidatePosition message ## [1.1.0] - 2024-01-15 ### A...


Near line 53: Possible typo: you repeated a word
Context: ...n` message ## [1.1.0] - 2024-01-15 ### Added - Added new functions in all Market classes to ...


Near line 62: Possible typo: you repeated a word
Context: ...ion files ## [1.0.1] - 2024-01-08 ### Added - Added low level API components for all module...


Near line 63: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... [1.0.1] - 2024-01-08 ### Added - Added low level API components for all modules (chain, ...


Near line 63: Possible spelling mistake found.
Context: ... API components for all modules (chain, exchain and explorer) to make the Python SDK co...


Near line 64: Possible spelling mistake found.
Context: ...TypeScript SDK. - Added support for all wasm module messages. - Added support for al...


Near line 69: Possible spelling mistake found.
Context: ...dexer v1.12.72 - Added new functions in AsyncClient to interact with chain, exchange and ex...


Near line 69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... chain, exchange and explorer using the low level API components - Marked old function si...


Near line 70: Possible spelling mistake found.
Context: ...PI components - Marked old function sin AsyncClient as deprecated (the functions will be re...


Near line 71: Possible spelling mistake found.
Context: ...Updated all API examples to use the new AsyncClient functions ## [1.0] - 2023-11-01 ### Ad...


Near line 74: Possible typo: you repeated a word
Context: ...nt functions ## [1.0] - 2023-11-01 ### Added - Added logic to support use of Client Order ID...


Near line 75: Possible spelling mistake found.
Context: ...Client Order ID (CID) new identifier in OrderInfo - New chain stream support ### Changed...


Near line 79: Possible spelling mistake found.
Context: ... - Remove support for sentry nodes in mainnet network. The only supported node option...


Near line 79: Possible spelling mistake found.
Context: ...work. The only supported node option in mainnet is lb - Migrated all proto objects de...


Near line 80: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...ported node option in mainnet is lb - Migrated all proto objects dependency to support...


Near line 82: Possible missing preposition found.
Context: ....md file to its own CHANGELOG.md file - Remove aiocron dependency. Use plain asyncio...


Near line 82: Possible spelling mistake found.
Context: ...e to its own CHANGELOG.md file - Remove aiocron dependency. Use plain asyncio tasks to...


Near line 82: Possible spelling mistake found.
Context: ... Remove aiocron dependency. Use plain asyncio tasks to solve the timeout height synch...


Near line 84: Possible spelling mistake found.
Context: ...n in all examples - Refactored logic in AsyncClient to load markets and tokens, to ensure t...


Near line 84: Possible spelling mistake found.
Context: ... are no duplicated tokens with the same denom ## [0.9.12] * Synchronized markets and...


Near line 87: Possible spelling mistake found.
Context: ...ets and tokens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and n...


Near line 87: Possible spelling mistake found.
Context: ...ens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spo...


Near line 87: Possible spelling mistake found.
Context: ...onfig files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot market...


Near line 87: Possible spelling mistake found.
Context: ...iles to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets #...


Near line 87: Possible spelling mistake found.
Context: ... KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets ## [0.9.11] ...


Near line 87: Possible spelling mistake found.
Context: ...J, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets ## [0.9.11] * Synchro...


Near line 87: Possible spelling mistake found.
Context: ...NJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets ## [0.9.11] * Synchronize...


Near line 90: Possible spelling mistake found.
Context: ... markets and tokens config files to add SEI/USDT and TIA/USDT perpetual markets ##...


Near line 96: Possible spelling mistake found.
Context: ... markets and tokens config files to add USDY/USDT and WHALE/USDT spot markets ## [0...


Near line 99: Possible spelling mistake found.
Context: ... markets and tokens config files to add PYTH/USDT spot market ## [0.9.7] * Added PY...


Near line 102: Possible spelling mistake found.
Context: ...TH/USDT spot market ## [0.9.7] * Added PYTH/USDT PERP market info in mainnet metada...


Near line 102: Possible spelling mistake found.
Context: ...] * Added PYTH/USDT PERP market info in mainnet metadata ini file ## [0.9.6] * Synchro...


Near line 102: Possible spelling mistake found.
Context: ...DT PERP market info in mainnet metadata ini file ## [0.9.6] * Synchronized denom i...


Near line 105: Possible spelling mistake found.
Context: ...ata ini file ## [0.9.6] * Synchronized denom ini files with Indexer information for ...


Near line 105: Possible spelling mistake found.
Context: ...i file ## [0.9.6] * Synchronized denom ini files with Indexer information for main...


Near line 105: Possible spelling mistake found.
Context: ... ini files with Indexer information for mainnet, testnet and devnet to include TALIS/IN...


Near line 105: Possible spelling mistake found.
Context: ...s with Indexer information for mainnet, testnet and devnet to include TALIS/INJ and KUJ...


Near line 105: Possible spelling mistake found.
Context: ...er information for mainnet, testnet and devnet to include TALIS/INJ and KUJI/USDT mark...


Near line 105: Possible spelling mistake found.
Context: ... mainnet, testnet and devnet to include TALIS/INJ and KUJI/USDT markets ## [0.9.5] *...


Near line 105: Possible spelling mistake found.
Context: ...et, testnet and devnet to include TALIS/INJ and KUJI/USDT markets ## [0.9.5] * Upd...


Near line 105: Possible spelling mistake found.
Context: ...net and devnet to include TALIS/INJ and KUJI/USDT markets ## [0.9.5] * Updated fetc...


Near line 108: Possible spelling mistake found.
Context: ...d fetch_metadata script (to synchronize denom ini files) to reuse logic in AsyncClien...


Near line 108: Possible spelling mistake found.
Context: ...h_metadata script (to synchronize denom ini files) to reuse logic in AsyncClient * ...


Near line 108: Possible spelling mistake found.
Context: ...nize denom ini files) to reuse logic in AsyncClient * Synchronized denom ini files with Ind...


Near line 109: Possible spelling mistake found.
Context: ...use logic in AsyncClient * Synchronized denom ini files with Indexer information for ...


Near line 109: Possible spelling mistake found.
Context: ...gic in AsyncClient * Synchronized denom ini files with Indexer information for main...


Near line 109: Possible spelling mistake found.
Context: ... ini files with Indexer information for mainnet, testnet and devnet ## [0.9.4] * Added...


Near line 109: Possible spelling mistake found.
Context: ...s with Indexer information for mainnet, testnet and devnet ## [0.9.4] * Added TIA/USDT...


Near line 109: Possible spelling mistake found.
Context: ...er information for mainnet, testnet and devnet ## [0.9.4] * Added TIA/USDT spot marke...


Near line 112: Possible spelling mistake found.
Context: ...[0.9.4] * Added TIA/USDT spot market in mainnet and testnet ini file ## [0.9.3] * Upda...


Near line 112: Possible spelling mistake found.
Context: ...ded TIA/USDT spot market in mainnet and testnet ini file ## [0.9.3] * Updated TIA/USDT...


Near line 112: Possible spelling mistake found.
Context: ...USDT spot market in mainnet and testnet ini file ## [0.9.3] * Updated TIA/USDT-30N...


Near line 115: This abbreviation for “identification” is spelled all-uppercase.
Context: ....3] * Updated TIA/USDT-30NOV2023 market id in denoms_mainnet.ini file ## [0.9.2] ...


Near line 115: Possible spelling mistake found.
Context: ...Updated TIA/USDT-30NOV2023 market id in denoms_mainnet.ini file ## [0.9.2] * Added fi...


Near line 118: Possible spelling mistake found.
Context: ...ini file ## [0.9.2] * Added fix to the grpc import error in Mac with M1 and M2 chip...


Near line 121: Possible spelling mistake found.
Context: ... ## [0.9.1] * Added new spot markets in mainnet ini file: KAVA/USDT, USDTkv/USDT * Adde...


Near line 121: Possible spelling mistake found.
Context: ....1] * Added new spot markets in mainnet ini file: KAVA/USDT, USDTkv/USDT * Added ne...


Near line 121: Possible spelling mistake found.
Context: ...d new spot markets in mainnet ini file: KAVA/USDT, USDTkv/USDT * Added new derivativ...


Near line 121: Possible spelling mistake found.
Context: ...markets in mainnet ini file: KAVA/USDT, USDTkv/USDT * Added new derivative markets in ...


Near line 122: Possible spelling mistake found.
Context: .../USDT * Added new derivative markets in mainnet ini file: TIA/USDT-30NOV2023, AXL/USDT,...


Near line 122: Possible spelling mistake found.
Context: ...Added new derivative markets in mainnet ini file: TIA/USDT-30NOV2023, AXL/USDT, BTC...


Near line 122: Possible spelling mistake found.
Context: ...file: TIA/USDT-30NOV2023, AXL/USDT, BTC/USDTkv, ETH/USDTkv ## [0.9.0] * Improvement i...


Near line 122: Possible spelling mistake found.
Context: ...DT-30NOV2023, AXL/USDT, BTC/USDTkv, ETH/USDTkv ## [0.9.0] * Improvement in broadcaste...


Near line 126: Possible spelling mistake found.
Context: ...out height only when required * Replace Pipenv with Poetry * Add pre-commit validation...


Near line 132: Possible spelling mistake found.
Context: ...verage for each PR ## [0.8.5] * Added NEOK/USDT and ORAI/USDT spot markets to the ...


Near line 132: Possible spelling mistake found.
Context: ...h PR ## [0.8.5] * Added NEOK/USDT and ORAI/USDT spot markets to the mainnet .ini f...


Near line 132: Possible spelling mistake found.
Context: .../USDT and ORAI/USDT spot markets to the mainnet .ini file ## [0.8.4] * Added methods t...


Near line 135: Possible spelling mistake found.
Context: ...ini file ## [0.8.4] * Added methods to SpotMarket, DerivativeMarket and BianaryOptionMark...


Near line 135: Possible spelling mistake found.
Context: ... [0.8.4] * Added methods to SpotMarket, DerivativeMarket and BianaryOptionMarket to translate ch...


Near line 135: Possible spelling mistake found.
Context: ...ods to SpotMarket, DerivativeMarket and BianaryOptionMarket to translate chain prices and quantitie...


Near line 144: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...ecure or insecure connection inside the Network class. The AsyncClient's insecure par...


Near line 144: Possible spelling mistake found.
Context: ...onnection inside the Network class. The AsyncClient's insecure parameter is no longer use...


Near line 145: Possible spelling mistake found.
Context: ...ced bare-metal node the default one for mainnet (it is called lb). The legacy one (lo...


Near line 149: Possible spelling mistake found.
Context: ...loads the required information from the Denoms used in previous versions * Change in A...


Near line 150: Possible spelling mistake found.
Context: ...s used in previous versions * Change in AsyncClient to be able to create Composer instances...


Near line 151: Possible spelling mistake found.
Context: ... to create Composer instances using the AsyncClient * Added new nodes (bare-metal load bala...


Near line 152: Possible spelling mistake found.
Context: ...s (bare-metal load balancing nodes) for mainnet and testnet * Deprecated the kubernetes...


Near line 152: Possible spelling mistake found.
Context: ...l load balancing nodes) for mainnet and testnet * Deprecated the kubernetes load balanc...


Near line 153: Possible spelling mistake found.
Context: ...or mainnet and testnet * Deprecated the kubernetes load balanced nodes for testnet * Refac...


Near line 153: Possible spelling mistake found.
Context: ... the kubernetes load balanced nodes for testnet * Refactored the cookies management log...


Near line 154: An apostrophe may be missing.
Context: ...nced nodes for testnet * Refactored the cookies management logic into a cookie assistan...


Near line 155: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...at for bare-metal load balanced nodes * Removed class Client. The only supported now is...


Near line 155: Possible spelling mistake found.
Context: ...pported now is the async version called AsyncClient. ## [0.7.1.1] * Fixed Testnet network ...


Near line 158: Possible spelling mistake found.
Context: ...lled AsyncClient. ## [0.7.1.1] * Fixed Testnet network URLs ## [0.7.2.1] * Synchroniz...


Near line 161: Possible spelling mistake found.
Context: ...URLs ## [0.7.2.1] * Synchronization of denoms configuration files. ## [0.7.2] * Adde...


Near line 164: Possible spelling mistake found.
Context: ...ded a new gas limit calculation for the TransactionBroadcaster that estimates the value based on the m...


Near line 167: Possible spelling mistake found.
Context: ...action simulation). ## [0.7.1.2] * Add NBLA ## [0.7.1.1] * Fixed Testnet network U...


Near line 170: Possible spelling mistake found.
Context: ...7.1.2] * Add NBLA ## [0.7.1.1] * Fixed Testnet network URLs ## [0.7.1] * Include impl...


Near line 173: Possible spelling mistake found.
Context: ...[0.7.1] * Include implementation of the TransactionBroadcaster, to simplify the transaction creation a...


Near line 176: Possible spelling mistake found.
Context: ...oadcasting process. ## [0.7.0.6] * ADD SEI/USDT in metadata ## [0.7.0.5] * Added ...


Near line 179: Possible spelling mistake found.
Context: ....0.5] * Added the required logic in the MsgSubaccountTransfer message to translate amounts and token ...


Near line 182: Possible spelling mistake found.
Context: ...4] * Synchronized decimals for ATOM and WETH in Testnet with the configuration provi...


Near line 182: Possible spelling mistake found.
Context: ...chronized decimals for ATOM and WETH in Testnet with the configuration provided by the ...


Near line 185: Possible spelling mistake found.
Context: ...ided by the indexer ## [0.7.0.3] * Add FRCOIN testnet ## [0.7.0.2] * Removed from As...


Near line 185: Possible spelling mistake found.
Context: ... the indexer ## [0.7.0.3] * Add FRCOIN testnet ## [0.7.0.2] * Removed from AsyncClien...


Near line 188: Possible spelling mistake found.
Context: ...IN testnet ## [0.7.0.2] * Removed from AsyncClient all references to the deprecated OrderB...


Near line 188: Possible spelling mistake found.
Context: ...Client all references to the deprecated OrderBook RPC endpoints (replaced them with Order...


Near line 189: Possible spelling mistake found.
Context: ...ed them with OrderBookV2) * Updated all orderbook examples ## [0.7] * Removed references...


Near line 196: Possible spelling mistake found.
Context: ...emoved k8s from the list of supported mainnet nodes (lb should be used instead) ##...


Near line 201: Possible spelling mistake found.
Context: ...rders for more than one market_id * Add pytest as a development dependency to impleme...


Near line 213: Possible spelling mistake found.
Context: ...## [0.6.2.1] * Remove version deps from Pipfile ## [0.6.2.0] * Add MsgUnderwrite, MsgR...


Near line 216: Possible spelling mistake found.
Context: ...n deps from Pipfile ## [0.6.2.0] * Add MsgUnderwrite, MsgRequestRedemption in Composer ## [...


Near line 216: Possible spelling mistake found.
Context: ...file ## [0.6.2.0] * Add MsgUnderwrite, MsgRequestRedemption in Composer ## [0.6.1.8] * Add MsgCrea...


Near line 219: Possible spelling mistake found.
Context: ...emption in Composer ## [0.6.1.8] * Add MsgCreateInsuranceFund in Composer * Re-gen mainnet denoms ##...


Near line 220: Possible spelling mistake found.
Context: ...reateInsuranceFund in Composer * Re-gen mainnet denoms ## [0.6.1.5] * Add MsgExecuteCo...


Near line 220: Possible spelling mistake found.
Context: ...uranceFund in Composer * Re-gen mainnet denoms ## [0.6.1.5] * Add MsgExecuteContract ...


Near line 223: Possible spelling mistake found.
Context: ...-gen mainnet denoms ## [0.6.1.5] * Add MsgExecuteContract in Composer ## [0.6.1.4] * Add wMATIC ...


Near line 226: Possible spelling mistake found.
Context: ...ontract in Composer ## [0.6.1.4] * Add wMATIC ## [0.6.1.2] * Add OrderbookV2 method ...


Near line 239: Possible spelling mistake found.
Context: ...ault * Proto re-gen ## [0.6.0.8] * Add USDCfr ## [0.6.0.7] * Add LDO ## [0.6.0.6] *...


Near line 242: Possible spelling mistake found.
Context: ...6.0.8] * Add USDCfr ## [0.6.0.7] * Add LDO ## [0.6.0.6] * Set default testnet end...


Near line 245: Possible spelling mistake found.
Context: ...] * Add LDO ## [0.6.0.6] * Set default testnet endpoints to K8S * Remove LB config for...


Near line 246: Possible spelling mistake found.
Context: ...endpoints to K8S * Remove LB config for testnet * Fix relative imports in composer * Ad...


Near line 248: Possible spelling mistake found.
Context: ... Fix relative imports in composer * Add AccountPortfolio & StreamAccountPortfolio ## [0.6.0.5] ...


Near line 248: Possible spelling mistake found.
Context: ...ts in composer * Add AccountPortfolio & StreamAccountPortfolio ## [0.6.0.5] * Add new testnet endpoin...


Near line 251: Possible spelling mistake found.
Context: ...ccountPortfolio ## [0.6.0.5] * Add new testnet endpoints * Re-gen mainnet denoms ## [...


Near line 252: Possible spelling mistake found.
Context: ...5] * Add new testnet endpoints * Re-gen mainnet denoms ## [0.6.0.4] * Remove explicit ...


Near line 252: Possible spelling mistake found.
Context: ... new testnet endpoints * Re-gen mainnet denoms ## [0.6.0.4] * Remove explicit version...


Near line 255: Possible spelling mistake found.
Context: ....6.0.4] * Remove explicit versions from protobuf and grpcio-tools dependencies ## [0.6....


Near line 255: Possible spelling mistake found.
Context: ...ove explicit versions from protobuf and grpcio-tools dependencies ## [0.6.0.2] * Re-gen mai...


Near line 258: Possible spelling mistake found.
Context: ...ols dependencies ## [0.6.0.2] * Re-gen mainnet denoms ## [0.6.0.0] * Change default n...


Near line 258: Possible spelling mistake found.
Context: ...ndencies ## [0.6.0.2] * Re-gen mainnet denoms ## [0.6.0.0] * Change default network ...


Near line 262: Possible spelling mistake found.
Context: ...* Change default network to LB * Re-gen mainnet denoms ## [0.5.9.7] * Re-gen mainnet d...


Near line 262: Possible spelling mistake found.
Context: ... default network to LB * Re-gen mainnet denoms ## [0.5.9.7] * Re-gen mainnet denoms ...


Near line 265: Possible spelling mistake found.
Context: ...n mainnet denoms ## [0.5.9.7] * Re-gen mainnet denoms ## [0.5.9.6] * Re-gen proto ##...


Near line 265: Possible spelling mistake found.
Context: ...t denoms ## [0.5.9.7] * Re-gen mainnet denoms ## [0.5.9.6] * Re-gen proto ## [0.5.9...


Near line 271: Possible spelling mistake found.
Context: ...9.6] * Re-gen proto ## [0.5.9.5] * Add orderbook snaphot methods ## [0.5.9.4] * Re-gen ...


Near line 271: Possible spelling mistake found.
Context: ...gen proto ## [0.5.9.5] * Add orderbook snaphot methods ## [0.5.9.4] * Re-gen mainnet ...


Near line 274: Possible spelling mistake found.
Context: ... snaphot methods ## [0.5.9.4] * Re-gen mainnet denoms ## [0.5.9.4] * Re-gen mainnet d...


Near line 274: Possible spelling mistake found.
Context: ... methods ## [0.5.9.4] * Re-gen mainnet denoms ## [0.5.9.4] * Re-gen mainnet denoms ...


Near line 277: Possible spelling mistake found.
Context: ...n mainnet denoms ## [0.5.9.4] * Re-gen mainnet denoms ## [0.5.9.2] * Fix margin conve...


Near line 277: Possible spelling mistake found.
Context: ...t denoms ## [0.5.9.4] * Re-gen mainnet denoms ## [0.5.9.2] * Fix margin conversion f...


Near line 283: Possible spelling mistake found.
Context: ...tions ## [0.5.9.1] * Add skip/limit to BinaryOptionsMarketsRequest ## [0.5.9.0] * Re-gen proto * Fix MsgR...


Near line 287: Possible spelling mistake found.
Context: ...uest ## [0.5.9.0] * Re-gen proto * Fix MsgRewardsOptOut * Remove pysha3 dependency ## [0.5.8.8...


Near line 291: Possible spelling mistake found.
Context: ...e pysha3 dependency ## [0.5.8.8] * Add grpc_explorer_endpoint in Network * Add expl...


Near line 296: Possible spelling mistake found.
Context: ...njective/constant.py#L166) must now set grpc_explorer_endpoint during init


Near line 296: Possible spelling mistake found.
Context: ...t now set grpc_explorer_endpoint during init

Additional comments not posted (2)
CHANGELOG.md (2)

7-10: The updates to the CHANGELOG.md correctly reflect the new features added to the IBC modules as described in the PR objectives and AI-generated summaries.


12-12: Ensure the description of the refactored cookies management logic is clear and accurately reflects the changes made. Consider specifying which cookies or aspects of the management logic were refactored for better clarity.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,6 +1,6 @@
from typing import Any, Callable, Dict, List, Optional

from grpc._cython.cygrpc import Channel
from grpc import Channel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the same, only using a non private name. Or is it a different module?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the end it is the same. I just feel it is better to use the general class

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
CHANGELOG.md (1)

Line range hint 87-291: Standardize the use of list markers throughout the document. Replace asterisks with dashes for list items to maintain consistency with the majority of the document.

- * Synchronized markets and tokens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets
+ - Synchronized markets and tokens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets

@aarmoa aarmoa merged commit 71e7f0c into dev Apr 22, 2024
12 checks passed
@aarmoa aarmoa deleted the feat/ibc_client_module_queries branch April 22, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants