-
Notifications
You must be signed in to change notification settings - Fork 34
feat/ibc_client_module_queries #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e scripts for all queries and unit tests
WalkthroughThis update expands support for IBC client queries in the Injective Protocol network, enhancing asynchronous client capabilities. It includes querying client states, consensus states, parameters, and statuses. The cookies management logic has been refined to leverage gRPC responses effectively. Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional Context UsedLanguageTool (141)
Additional comments not posted (2)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -1,6 +1,6 @@ | |||
from typing import Any, Callable, Dict, List, Optional | |||
|
|||
from grpc._cython.cygrpc import Channel | |||
from grpc import Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the same, only using a non private name. Or is it a different module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in the end it is the same. I just feel it is better to use the general class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
CHANGELOG.md (1)
Line range hint
87-291
: Standardize the use of list markers throughout the document. Replace asterisks with dashes for list items to maintain consistency with the majority of the document.- * Synchronized markets and tokens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets + - Synchronized markets and tokens config files to add KIRA/INJ, NINJA/INJ, KATANA/INJ, BRETT/INJ and nINJ/INJ spot markets
Solves CHAIN-80
Summary by CodeRabbit
New Features
Refactor
Documentation
Tests