Bugfix: Fix event generator to be in the target, not downstream (MAJOR) #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a sign error, the events were generated around +4587 mm instead of around -4587 mm. The call to GetFrameTranslation should have been a call to GetTranslation, or various equivalent sign changes. This was not a problem before since the target was centered at zero, and so -0 is the same...
|
I haven't noticed this issue. Which branches were affected by this and was this error introduced recently or has it always been the case? |
|
This doesn't affect the beam generator so you may not have been affected. The bug here was introduced when the geometry was changed in May. I do think everyone was probably affected by the absence of the magnetic field shift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a sign error, the events were generated around +4587 mm instead
of around -4587 mm. The call to GetFrameTranslation should have been a
call to GetTranslation, or various equivalent sign changes.
This was not a problem before since the target was centered at zero, and
so -0 is the same...