Release/5.3.0 #357
Merged
Release/5.3.0 #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Typos and grammatical mitsakes ; )
Remove duplicated texts.
Duplicated Chart but altered it to use the standard grouping data structure and implemented a line gate that produces a path for each line. Also added a story for a grouped set of lines.
Remove commented out extranious imports.
Replicated the structure for grouped bar charts for stacked bar charts. Also, seperated out the generation of extent, indexes, and series for stacked bar so they could be overriden for grouped data.
Added a Grouped story for StackedBarChart. It seems like I'm doing something wrong here, generate enough areas, but some of them have `NaN` in the path data.
The stacked bar groups no longer extends the stacked bars because everything is now overriden. The last issue I had was that the last group kept coming out with NaN in its path data. This was due to the miscalculation of the Scale based on the indexes of the top level data as Stacked Bars does it. Also, the indexes needed to be calculated off of the number of groups instead of the number of total bars. Also removed any test code left in.
Added a story for horizontal groups of stacked bars.
For both single and grouped stacked bars, bandwidth was added to their child props.
It looks like now in RN 0.57 there is a bug that `transparent` doesn't work properly with `View` component without `backgroundColor` specified.
Fix 'transparent' color for X-Axis and Y-Axis in RN 0.57
Update README.md
XAxis/YAxis crash fix
Following the example from the charts, this adds extra props fro use in laying out axes children to both the x and y axes.
…h-bar-new Group StackedBarCharts
…s-new Grouped Line Charts
Added extra props to axis children
looking for maintainers
Using an index for a key in RN is not advised, it does not provide a key that is maintainable and does not properly update each node. It's complicated but there are some very good write-ups on this. this lead to odd spacing dispite y(value) returning proper values. The items simply weren't rerendering.
- Added space between bars - Added radius to vertical bars
If the borderRadius is bigger than the barHeight should be scaled proportionally
add required library version
This makes the path animation compatible with InteractionManager.runAfterInteractions
Create interaction handle during animation
Animation blinks to new value, then animates, because the d prop is passed through to the path, before being animated by _animate
prevent crash on undefined data
Fix YAxis using Unnecessary max/min value before definition
Fix blinking animation
Added more props to axis children
Stacked Area Chart: Pass `areas` down to children
Formatting/prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.