Skip to content

feat: add ":(" to the end of type: bug label description #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

feat: add ":(" to the end of type: bug label description #456

merged 1 commit into from
May 20, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented May 20, 2023

PR Checklist

Overview

Add ":(" to the end of type: bug label description to make it more interesting

JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 20, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfect! Thanks @tungbq - this is one of the fastest new issue -> resolved PR time frames I've ever seen! 😄

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #456 (7a67d71) into main (d95fdf1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files          23       23           
  Lines         122      122           
  Branches       42       42           
=======================================
  Hits           90       90           
  Misses         10       10           
  Partials       22       22

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tungbq tungbq changed the title 🚀 Feature: Add ":(" to the end of type: bug label description feat: add ":(" to the end of type: bug label description May 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 20, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5d6311a into JoshuaKGoldberg:main May 20, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @tungbq for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request May 20, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @tungbq! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request May 20, 2023
@allcontributors
docs: add tungbq as a contributor for code (#459)
29e7267 
Adds @tungbq as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#456 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@tungbq tungbq deleted the decorate-bug-label branch May 20, 2023 15:18
@tungbq
Copy link
Contributor Author

tungbq commented May 20, 2023

Thank you @JoshuaKGoldberg !

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add ":(" to the end of type: bug label description
2 participants
@tungbq @JoshuaKGoldberg