Skip to content

fix(namespaces): only report when there is value emit #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Changes the rule to not report when no value emit child is found in a namespace.

Adds cached-factory as a dependency to cache checks on individual namespace nodes. Parent namespaces need to check their child namespaces.

💖

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a454e11) to head (ccb9f57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          143       174   +31     
  Branches         5        18   +13     
=========================================
+ Hits           143       174   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit e82fea5 into main Feb 17, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the namespaces-check-for-values branch February 17, 2025 18:54
Copy link

🎉 This is included in version v0.2.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Don't flag namespaces that only produce types (no value emit)
1 participant