Skip to content

Fix ConstantSpace Multiplication for empty coefficients #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 12, 2023

After this, the following works (the Fun has an empty coefficient vector):

julia> C = Multiplication(Fun(ConstantSpace(), Float64[]), ConstantSpace())
ConcreteMultiplication : ConstantSpace  ConstantSpace
 0.0

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (28eb4ea) 75.24% compared to head (3116a52) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files          80       80           
  Lines        8421     8427    +6     
=======================================
+ Hits         6336     6341    +5     
- Misses       2085     2086    +1     
Files Changed Coverage Δ
src/Spaces/ConstantSpace.jl 58.53% <77.77%> (+1.27%) ⬆️
src/show.jl 97.22% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 3270d7d into JuliaApproximation:master Sep 12, 2023
@jishnub jishnub deleted the constspmul branch September 12, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant