reduce occurences of tag errors #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These seem sensible to me. Rebase against master to get the Kristoffer's shiny new appveyor file?
lol Coveralls. |
|
Are the appveyor failures expected? |
|
bump: any ideas what is going on here? |
|
Windows tests have been kind of broken for awhile; the tests seem more sensitive to the finite differencing error. Would be worth figuring out at some point but it's unrelated to this PR. |
|
can you tag a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested differentiation can fail in cases where there are no operations involving the inner gradient, e.g.
I'm pretty sure this is safe...