Skip to content

Remove rule for conj #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Remove rule for conj #532

merged 4 commits into from
Jul 28, 2021

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Jul 5, 2021

Special case now handled by DiffRules.

However, to delete this, I think this needs a high lower bound on DiffRules. Or it needs an if to check whether DiffRules has the rule yet.

Closes #531

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #532 (4c0f4b9) into master (ea822d2) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   84.72%   84.81%   +0.09%     
==========================================
  Files           9        9              
  Lines         825      830       +5     
==========================================
+ Hits          699      704       +5     
  Misses        126      126              
Impacted Files Coverage Δ
src/dual.jl 72.63% <ø> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea822d2...4c0f4b9. Read the comment docs.

@KristofferC KristofferC marked this pull request as ready for review July 28, 2021 09:29
@KristofferC KristofferC merged commit 27e1a8d into JuliaDiff:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

method conj overwritten in dual.jl
3 participants