Skip to content

Add AbstractIrrational to list of types for TrackedReal promote_rule definitions #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

ElOceanografo
Copy link
Contributor

Should fix #100.

Similar to this PR for ForwardDiff: JuliaDiff/ForwardDiff.jl#687

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@devmotion devmotion merged commit a30ddcf into JuliaDiff:master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous Promotion Rule for <:Irrational,<:ReverseDiff.TrackedReal{V,D,O}}
2 participants