-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix eigvecs(:::SymTridiagonal) with longer off-diagonal vector #40526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is dropping the new eigvals!(A::SymTridiagonal{<:BlasReal})
definition intentional?
What do you mean? I haven't touched any |
The PR this closes had an additional change to stdlib/LinearAlgebra/src/tridiag.jl not included here |
Oh, sorry, yes, that was fixed in #40165. That additional change was in fact superfluous because it shortened the |
…Lang#40526) Co-authored-by: Marcelo Forets <[email protected]>
…Lang#40526) Co-authored-by: Marcelo Forets <[email protected]>
Co-authored-by: Marcelo Forets <[email protected]> (cherry picked from commit 3428e88)
Co-authored-by: Marcelo Forets <[email protected]> (cherry picked from commit 3428e88)
Co-authored-by: Marcelo Forets <[email protected]> (cherry picked from commit 3428e88)
…Lang#40526) Co-authored-by: Marcelo Forets <[email protected]>
Co-authored-by: Marcelo Forets <[email protected]> (cherry picked from commit 3428e88)
Fixes
eigvecs(::SymTridiagonal, eigvals)
, akaLAPACK.stein!
, for longer off-diagonal vectors. Closes #38833.Co-authored-by: Marcelo Forets [email protected]