Skip to content

Fix eigvecs(:::SymTridiagonal) with longer off-diagonal vector #40526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

dkarrasch
Copy link
Member

Fixes eigvecs(::SymTridiagonal, eigvals), aka LAPACK.stein!, for longer off-diagonal vectors. Closes #38833.

Co-authored-by: Marcelo Forets [email protected]

@dkarrasch dkarrasch added the linear algebra Linear algebra label Apr 19, 2021
@dkarrasch dkarrasch changed the title dk/stein! Fix eigvecs(:::SymTridiagonal) with longer off-diagonal vector Apr 19, 2021
@dkarrasch dkarrasch requested a review from vtjnash April 19, 2021 15:39
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is dropping the new eigvals!(A::SymTridiagonal{<:BlasReal}) definition intentional?

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 19, 2021
@dkarrasch
Copy link
Member Author

is dropping the new eigvals!(A::SymTridiagonal{<:BlasReal}) definition intentional?

What do you mean? I haven't touched any eigvals methods, have I?

@vtjnash
Copy link
Member

vtjnash commented Apr 19, 2021

The PR this closes had an additional change to stdlib/LinearAlgebra/src/tridiag.jl not included here

@dkarrasch
Copy link
Member Author

Oh, sorry, yes, that was fixed in #40165. That additional change was in fact superfluous because it shortened the ev in the high-level function even though that was unnecessary in the LAPACK method.

@dkarrasch dkarrasch removed the merge me PR is reviewed. Merge when all tests are passing label Apr 20, 2021
@dkarrasch dkarrasch merged commit 3428e88 into master Apr 20, 2021
@dkarrasch dkarrasch deleted the dk/stein! branch April 20, 2021 07:38
@fredrikekre fredrikekre added the backport 1.6 Change should be backported to release-1.6 label Apr 20, 2021
@KristofferC KristofferC mentioned this pull request May 4, 2021
45 tasks
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
KristofferC pushed a commit that referenced this pull request Jun 10, 2021
KristofferC pushed a commit that referenced this pull request Jun 10, 2021
KristofferC pushed a commit that referenced this pull request Jun 11, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants