inference: properly compare vararg-tuple PartialStructs
#44966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just found this case from code review, but this `Vararg` should be widened.
aviatesk
changed the title
PartialStructsPartialStructs
vtjnash
reviewed
Apr 13, 2022
| @@ -313,7 +313,7 @@ function issimplertype(@nospecialize(typea), @nospecialize(typeb)) | |||
| if typea isa PartialStruct | |||
| aty = widenconst(typea) | |||
| for i = 1:length(typea.fields) | |||
| ai = typea.fields[i] | |||
| ai = unwrapva(typea.fields[i]) | |||
There was a problem hiding this comment.
is Vararg{T,N} simpler-than T? I think so, per the comment in __limit_type_size, but just wanted to confirm
There was a problem hiding this comment.
I think the main reason that justifies this change is that ai is finally compared with fieldtype(aty, i)/getfield_tfunc(typeb, Const(i)), which essentially unwraps Vararg{T} to T.
There was a problem hiding this comment.
This function is not symmetric in the arguments, so that reasoning does not justify it
|
LibGit2 seems to have run into some internal memory corruption problems as commonly happens, but doesn't seem like anything is related to this PR |
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
issimplertypequery.Fix #44965.
Unrelated but another commit also adds
one more missing
Vararghandlingfound from a code review.