This repository was archived by the owner on May 23, 2022. It is now read-only.
Reset to original interface state (attempt 2) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to manually revert each commit then cherry pick a few of them. Git reset won't work in this situation. |
Closed
|
I verified locally that the corresponding PRs to JuliaML/MLDataPattern.jl#65 and JuliaML/MLLabelUtils.jl#46 pass with this PR branch. I could force add the Manifest.toml in on those PRs if we want to run the CI. |
|
merged and tagged new version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the recent changes made in v0.5 to the observation interface. We will release v0.6. MLDataPattern.jl/MLLabelUtils.jl will be compatible with v0.4 and v0.6 (effectively negating v0.5).
See JuliaML/MLUtils.jl#2.